Skip to content

Conversation

@jhamman
Copy link
Member

@jhamman jhamman commented Oct 9, 2025

This PR replaces the crc32c dependency with the google-crc32c package. The behavior of the codec is not expected to have changed.

Closes zarr-developers/zarr-python#3510

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.75%. Comparing base (e59950d) to head (e4225c0).

Files with missing lines Patch % Lines
numcodecs/tests/test_checksum32.py 22.22% 7 Missing ⚠️
numcodecs/checksum32.py 16.66% 5 Missing ⚠️

❌ Your patch check has failed because the patch coverage (20.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (88.75%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
- Coverage   89.12%   88.75%   -0.38%     
==========================================
  Files          64       64              
  Lines        2547     2560      +13     
==========================================
+ Hits         2270     2272       +2     
- Misses        277      288      +11     
Files with missing lines Coverage Δ
numcodecs/checksum32.py 92.00% <16.66%> (-3.84%) ⬇️
numcodecs/tests/test_checksum32.py 81.91% <22.22%> (-6.33%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhamman
Copy link
Member Author

jhamman commented Oct 9, 2025

The failing tests here are due to a nasty circular dependency in our test suite with respect to zarr-python. I don't believe there is anything that can be done about that here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop numcodecs[crc32c] as dependency due to use of LGPL license

2 participants