V2 groups #25
Open
V2 groups #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/test/java/dev/zarr/zarrjava/ZarrTest.java
…; add new tests for array and group creation
normanrz
approved these changes
Oct 6, 2025
dominikl
reviewed
Oct 7, 2025
|
|
||
| StoreHandle storeHandle(); | ||
| protected CodecPipeline codecPipeline; | ||
| protected abstract ArrayMetadata metadata(); |
There was a problem hiding this comment.
Could this be made public (same for Group.metadata()), then the public metadata field in the implementation could be made private/protected instead? At the moment it's tricky to access the metadata (need explicit cast to v2.Array or v3.Array and access public metadata field).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Furthermore, the multi-inheritance strategy of
v3.Arrayfromcore.Arrayandv3.Nodewas changed so thatv3.Nodeis now an interface and core.Array is now an abstract class. Similar changes were made tov3.Codec,v2.Codec, andv2.Array.(this PR is on top of #22)