Expose get_node() in the public API #2947
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-v-b
reviewed
Apr 17, 2025
| Removed store API | ||
| ^^^^^^^^^^^^^^^^^ | ||
|
|
||
| ``zarr.storage.contains_array()`` and ``zarr.storage.contains_group()`` have been removed. |
There was a problem hiding this comment.
contains_array and contains_group have not been removed
There was a problem hiding this comment.
From a user perspective they have, because they're in a private sub-module. I can make them public in this PR if they were always intended to be public?
There was a problem hiding this comment.
I think we can say that contains_array and contains_group are not yet part of the public API. I don't have any problem adding them to the public API but maybe that's better for another PR.
There was a problem hiding this comment.
Well since putting them back in the public API would make this migration guide section redundant, I think I'll just put them back in a PR to replace this one at some point 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2934.
TODO:
docs/user-guide/*.rstchanges/