-
-
Notifications
You must be signed in to change notification settings - Fork 325
Add more unit tests for GPU buffer #2978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@TomAugspurger would you expect the sharding codec to work with the gpu buffer prototype? If so, I could debug the failure more but don't want to spend time setting up an environment with cuda unnecessarily |
I haven't used or looked at the sharding code, so I don't know offhand sorry. If setting up a dev end with cupy is a hassle I can take a look sometime. Just looking at the traceback, maybe one thing to check: try setting |
cc @madsbk @akshaysubr (in case either of you have thoughts on this question) |
Its been a while since I looked at the sharding codec, but it was not expected to work with the GPU buffer prototype. Might be worth another closer look but it seemed like some things in the sharding codec need to still be generalized to work with arbitrary buffer prototypes. |
the sharding codec is unique because it does IO, and thus interacts with a store, which might be the root of the complication here. (I would argue it is not really a codec in the conventional sense, and is rather a special implementation of an array). |
This PR adds some tests for the GPU buffer prototype to unlock #2738.