Skip to content

ruff rules: TCH → TC #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ruff rules: TCH → TC #3032

wants to merge 3 commits into from

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented May 4, 2025 •
edited
Loading

Ruff v0.8.0 changes the error codes for the rules in the flake8-type-checking category from TCH to TC.

Not sure about applying TC006:

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@DimitriPapadopoulos
The ruff ruleset is TC, not TCH
8a04207
@DimitriPapadopoulos
Apply ruff/flake8-type-checking rule TC006
14b59ef 
TC006 Add quotes to type expression in `typing.cast()`
@DimitriPapadopoulos
Apply ruff/flake8-type-checking rule TC003
eafcac0 
TC003 Move standard library import into a type-checking block
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 4, 2025
@dstansby dstansby mentioned this pull request May 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DimitriPapadopoulos