-
Notifications
You must be signed in to change notification settings - Fork 31
Add first upsert methods for Deals and Contact #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
redroot
wants to merge
9
commits into
zendesk:master
Choose a base branch
from
carwow:add-deal-upsert
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0ea6dac
adds deals service upsert
06356c5
adds deals service upsert
f96d4a9
adds specs
84195f5
remvoe wierd extra file
0798f7b
adds contact upsert
8046592
improve specs
29c8bd5
Update lib/basecrm/services/contacts_service.rb
redroot a2917a3
Update lib/basecrm/services/contacts_service.rb
redroot 70927cc
Update lib/basecrm/services/contacts_service.rb
redroot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ | |
| it { should respond_to :destroy } | ||
| it { should respond_to :find } | ||
| it { should respond_to :update } | ||
| it { should respond_to :upsert } | ||
| it { should respond_to :where } | ||
|
|
||
| end | ||
|
|
@@ -59,6 +60,22 @@ | |
| end | ||
| end | ||
|
|
||
| describe :upsert do | ||
| it 'raises a TypeError if filters is nil' do | ||
| expect(client.deals.upsert(nil, { name: 'unique_name' }).to raise_error(TypeError) | ||
| end | ||
|
|
||
| it 'raises an ArgumentError if filters is empty' do | ||
| expect(client.deals.upsert({}, { name: 'unique_name' }).to raise_error(ArgumentError) | ||
| end | ||
|
|
||
| it 'calls the upsert route with encoded filters' do | ||
| filters = { name: 'unique_name', 'custom_fields[external_id]': 'unique-1' } | ||
| attributes = filters.merge('custom_fields[category]': 'bags') | ||
| expect(client.deals.upsert(filters, attributes)).to be_instance_of BaseCRM::Deal | ||
|
||
| end | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above |
||
| end | ||
|
|
||
| describe :destroy do | ||
| it "returns true on success" do | ||
| @deal = create(:deal) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was trying to find a way on encoding the hash without using Rails only methods (like Object.to_query) or a new gem like Addressable, this seems to do the trick, but other opinions welcome