Skip to content

useless 'instanceof' removal pass #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

useless 'instanceof' removal pass #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Optimizer/pass1_5.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,20 @@ if (ZEND_OPTIMIZER_PASS_1 & OPTIMIZATION_LEVEL) {

while (opline < end) {
switch (opline->opcode) {
case ZEND_INSTANCEOF:
if ((opline + 1)->opcode == ZEND_FREE) { /* useless instanceof */
MAKE_NOP(opline);
MAKE_NOP((opline + 1));

/* It is safe to remove FETCH_CLASS, it was ZEND_FETCH_CLASS_NO_AUTOLOAD anyway */
if ((opline - 1)->opcode == ZEND_FETCH_CLASS) {
if (ZEND_OP2_TYPE(opline - 1) == IS_CONST) {
literal_dtor(&ZEND_OP2_LITERAL(opline - 1));
}
MAKE_NOP((opline -1));
}
}
break;
case ZEND_ADD:
case ZEND_SUB:
case ZEND_MUL:
Expand Down