fix: getInput returns empty string instead of null when no input is g…

…iven
zentered · Nov 29, 2021 · aa33eec · aa33eec
1 parent add1734
commit aa33eec
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 17 deletions.
diff --git a/cloudflare.mjs b/cloudflare.mjs
@@ -37,13 +37,6 @@ export default async function getDeploymentUrl(
   core.debug(`Looking for matching deployments ${repo}/${branch}`)
 
   const builds = data.result
-    .map((d) => {
-      core.info('-- temporary debugging --')
-      core.info(
-        `sha: ${commitHash}, ${typeof commitHash} ${commitHash === null}`
-      )
-      return d
-    })
     .filter(
       (d) =>
         d && d.source && d.source.config && d.source.config.repo_name === repo

diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/index.mjs b/index.mjs
@@ -18,7 +18,8 @@ async function run() {
     const projectId = core.getInput('cloudflare_project_id')
     const waitForDeploymentReady = core.getInput('wait_until_ready')
     const environment = core.getInput('environment', { required: false })
-    const commitHash = core.getInput('commit_hash', { required: false })
+    const inputHash = core.getInput('commit_hash', { required: false })
+    const commitHash = inputHash === '' || inputHash === null ? null : inputHash
 
     core.info(
       `Retrieving deployment preview for ${githubRepo}/${githubBranch} ...`