drivers: ethernet: phy: move genphy_*_plca_* function#108139
Open
maass-hamburg wants to merge 1 commit intozephyrproject-rtos:mainfrom
Open
drivers: ethernet: phy: move genphy_*_plca_* function#108139maass-hamburg wants to merge 1 commit intozephyrproject-rtos:mainfrom
maass-hamburg wants to merge 1 commit intozephyrproject-rtos:mainfrom
Conversation
These functions are from phy_oa_tc14_plca.c, which is only a helper for phys to implement the set_plca_cfg, get_plca_cfg and get_plca_sts functions of the ethernet_phy api, therefore they should be internal. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions are from phy_oa_tc14_plca.c, which is only a helper for phys to implement the set_plca_cfg, get_plca_cfg and get_plca_sts functions of the ethernet_phy api, therefore they should be internal.