Skip to content

drivers: ethernet: phy: add condition for the plca related api functions #108140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maass-hamburg wants to merge 1 commit into
base: main
Choose a base branch
from
+28 −3
Open

drivers: ethernet: phy: add condition for the plca related api functions #108140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions drivers/ethernet/phy/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ source "drivers/ethernet/phy/Kconfig.dm8806"
source "drivers/ethernet/phy/Kconfig.microchip_t1s"
source "drivers/ethernet/phy/Kconfig.nxp_t1s"

config ETH_PHY_API_PLCA
bool
help
Ethernet phy drivers should select this, if they implement the plca
related api functions

config PHY_INIT_PRIORITY
int "Ethernet PHY driver init priority"
default ETH_INIT_PRIORITY
Expand Down
1 change: 1 addition & 0 deletions drivers/ethernet/phy/Kconfig.microchip_t1s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ config PHY_MICROCHIP_T1S
depends on DT_HAS_MICROCHIP_T1S_PHY_ENABLED
select MDIO
select PHY_OA_TC14_PLCA_LIB
select ETH_PHY_API_PLCA
help
Enable Microchip's LAN8650/1 Rev.B0/B1 Internal PHYs and
LAN8670/1/2 Rev.C1/C2/D0 PHYs Driver.
1 change: 1 addition & 0 deletions drivers/ethernet/phy/Kconfig.nxp_t1s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ config PHY_NXP_T1S
bool "NXP 10BASE-T1S Ethernet PHY Driver"
default y
depends on DT_HAS_NXP_T1S_PHY_ENABLED
select ETH_PHY_API_PLCA
help
Enable NXP 10BASE-T1S PHY Driver.
23 changes: 20 additions & 3 deletions include/zephyr/net/phy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ __subsystem struct ethphy_driver_api {
/** Write PHY C45 register */
int (*write_c45)(const struct device *dev, uint8_t devad, uint16_t regad, uint16_t data);

#if defined(CONFIG_ETH_PHY_API_PLCA) || defined(__DOXYGEN__)
/* Set PLCA settings */
int (*set_plca_cfg)(const struct device *dev, struct phy_plca_cfg *plca_cfg);

Expand All @@ -211,6 +212,7 @@ __subsystem struct ethphy_driver_api {

/* Get PLCA status */
int (*get_plca_sts)(const struct device *dev, bool *plca_sts);
#endif /* CONFIG_ETH_PHY_API_PLCA */
};
/**
* @endcond
Expand Down Expand Up @@ -394,13 +396,18 @@ static inline int phy_write_c45(const struct device *dev, uint8_t devad, uint16_
* @retval 0 If successful.
* @retval -EIO If communication with PHY failed.
*/
static inline int phy_set_plca_cfg(const struct device *dev, struct phy_plca_cfg *plca_cfg)
static inline int phy_set_plca_cfg(__maybe_unused const struct device *dev,
__maybe_unused struct phy_plca_cfg *plca_cfg)
{
#if defined(CONFIG_ETH_PHY_API_PLCA)
if (DEVICE_API_GET(ethphy, dev)->set_plca_cfg == NULL) {
return -ENOSYS;
}

return DEVICE_API_GET(ethphy, dev)->set_plca_cfg(dev, plca_cfg);
#else
return -ENOSYS;
#endif /* CONFIG_ETH_PHY_API_PLCA */
}

/**
Expand All @@ -414,13 +421,18 @@ static inline int phy_set_plca_cfg(const struct device *dev, struct phy_plca_cfg
* @retval 0 If successful.
* @retval -EIO If communication with PHY failed.
*/
static inline int phy_get_plca_cfg(const struct device *dev, struct phy_plca_cfg *plca_cfg)
static inline int phy_get_plca_cfg(__maybe_unused const struct device *dev,
__maybe_unused struct phy_plca_cfg *plca_cfg)
{
#if defined(CONFIG_ETH_PHY_API_PLCA)
if (DEVICE_API_GET(ethphy, dev)->get_plca_cfg == NULL) {
return -ENOSYS;
}

return DEVICE_API_GET(ethphy, dev)->get_plca_cfg(dev, plca_cfg);
#else
return -ENOSYS;
#endif /* CONFIG_ETH_PHY_API_PLCA */
}

/**
Expand All @@ -434,13 +446,18 @@ static inline int phy_get_plca_cfg(const struct device *dev, struct phy_plca_cfg
* @retval 0 If successful.
* @retval -EIO If communication with PHY failed.
*/
static inline int phy_get_plca_sts(const struct device *dev, bool *plca_status)
static inline int phy_get_plca_sts(__maybe_unused const struct device *dev,
__maybe_unused bool *plca_status)
{
#if defined(CONFIG_ETH_PHY_API_PLCA)
if (DEVICE_API_GET(ethphy, dev)->get_plca_sts == NULL) {
return -ENOSYS;
}

return DEVICE_API_GET(ethphy, dev)->get_plca_sts(dev, plca_status);
#else
return -ENOSYS;
#endif /* CONFIG_ETH_PHY_API_PLCA */
}

#ifdef __cplusplus
Expand Down
Loading