drivers: usb: uhc: initial support for UHC driver on Renesas RA family #82730

thenguyenyf · 2024-12-09T11:54:40Z

This PR to initial support for UHC driver on Renesas RA boards.

zephyrbot · 2024-12-09T11:55:37Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

drivers/usb/uhc/uhc_renesas_ra.c

thenguyenyf · 2025-08-25T06:53:10Z

Last push to rebase and solve conflict

drivers/usb/uhc/uhc_renesas_ra.c

thenguyenyf · 2025-09-11T08:49:15Z

Hello @jfischer-no. Is there any chance this PR could be merged? All review items have been fixed but this PR is still blocked due to your change request. Could you please review and verify?

jfischer-no · 2025-09-23T14:35:56Z

Hello @jfischer-no. Is there any chance this PR could be merged? All review items have been fixed but this PR is still blocked due to your change request. Could you please review and verify?

Hello @thenguyenyf #82730 (comment) still not addressed, , there is not reason to add board overlays.

thenguyenyf · 2025-09-23T15:47:07Z

Hello @jfischer-no. Is there any chance this PR could be merged? All review items have been fixed but this PR is still blocked due to your change request. Could you please review and verify?

Hello @thenguyenyf #82730 (comment) still not addressed, , there is not reason to add board overlays.

Hello @jfischer-no . Please verify it

thenguyenyf · 2025-09-23T16:07:55Z

Last push just to rebase main

thenguyenyf · 2025-09-25T12:31:57Z

Hello @jfischer-no. Is there any chance this PR could be merged? All review items have been fixed but this PR is still blocked due to your change request. Could you please review and verify?

Hello @thenguyenyf #82730 (comment) still not addressed, , there is not reason to add board overlays.

Hello @jfischer-no . Please verify it

Hello @jfischer-no . Could you please revisit and verify this change?

jfischer-no · 2025-09-25T14:14:31Z

drivers/usb/uhc/uhc_renesas_ra.c

+	struct uhc_renesas_ra_evt event = {.type = UHC_RENESAS_RA_EVT_HAL,
+					   .hal_evt = p_args->event};


Please fix style.

jfischer-no · 2025-09-25T14:17:37Z

drivers/usb/uhc/uhc_renesas_ra.c

+	int err;
+
+	err = R_USBH_XferStart(&priv->uhc_ctrl, xfer->udev->addr, xfer->ep, buffer_tail, len);
+


Please remove this empty line.

jfischer-no · 2025-09-25T14:22:56Z

drivers/usb/uhc/uhc_renesas_ra.c

+}
+
+static int uhc_renesas_ra_edpt_open(const struct device *dev, uint8_t dev_addr, uint8_t attrib,
+				    uint8_t ep, uint8_t max_packet_size)


static int uhc_renesas_ra_edpt_open(const struct device *dev, const uint8_t dev_addr, const uint8_t attrib, const uint8_t ep, const uint8_t mps)

jfischer-no · 2025-09-25T14:23:46Z

drivers/usb/uhc/uhc_renesas_ra.c

+		return -EINVAL;
+	}
+
+	usb_desc_endpoint_t ep0_desc = {.bLength = sizeof(usb_desc_endpoint_t),


Variable definition should be at the top of a block. Please fix style.
Why is the name ep0_desc?

Done. The name was changed to ep_desc

There is now unnecessary type conversion, please change it to

const struct uhc_renesas_ra_config *config = dev->config; usb_desc_endpoint_t ep_desc = { .bDescriptorType = USB_DT_ENDPOINT, .bEndpointAddress = ep, .bmAttributes = {attrib}, .wMaxPacketSize = mps, .bInterval = 0, }; fsp_err_t err;

drivers/usb/uhc/uhc_renesas_ra.c

drivers/usb/udc/Kconfig.renesas_ra

jfischer-no · 2025-09-25T14:37:20Z

dts/bindings/usb/renesas/renesas,ra-usbhs.yaml

+  bus-wait-cycles:
+    type: int
+    description: Specifies CPU bus access wait cycles
+


Stray change? I do not think it is UHC relevant. Where is it used?

It is a setting for this HWIP and being used in the HAL: https://github.com/zephyrproject-rtos/hal_renesas/blob/main/zephyr/ra/ra_cfg/fsp_cfg/r_usb_host_cfg.h#L33

This commit adds a new property that is already exclusively used in the HAL driver configuration. Devicetree should be used to configure drivers in Zephyr. The HAL driver or HAL module must not depend on anything from Zephyr. You have to fix it, see https://github.com/zephyrproject-rtos/zephyr/tree/main/modules, also there is no obligation to use HAL drivers.

jfischer-no · 2025-09-25T14:41:28Z

drivers/usb/uhc/uhc_renesas_ra.c

+	static const struct uhc_renesas_ra_config uhc_config_##n = {                               \
+		.pcfg = PINCTRL_DT_DEV_CONFIG_GET(DT_INST_PARENT(n)),                              \
+		.make_thread = uhc_renesas_ra_create_thread_##n,                                   \
+		.udev_count = DT_PROP_OR(DT_INST_PARENT(node_id), usb_devices_count, 10),          \


Why is it a DT property and why does it need to be configured per instance? I see it only used in the shim driver. Why is 10 default value?

This HWIP only support up to 10 devices connected to. So, the 0xb or higher address is invalid for this driver.

why does it need to be configured per instance? Are there SoC variants where it has a different value?

First commit to support UHC driver for Renesas RA family Signed-off-by: Minh Hoang <[email protected]> Signed-off-by: The Nguyen <[email protected]>

Add device node to support UHC on Renesas RA SoCs Signed-off-by: Minh Hoang <[email protected]> Signed-off-by: The Nguyen <[email protected]>

Enable USB host support on Renesas RA boards Signed-off-by: Minh Hoang <[email protected]> Signed-off-by: The Nguyen <[email protected]>

Support USBH shell sample for renesas,ra-uhc Signed-off-by: The Nguyen <[email protected]>

sonarqubecloud · 2025-09-26T04:31:52Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

thenguyenyf · 2025-09-29T08:28:54Z

Hello @jfischer-no . Could you please re-visit this PR and verify the change request?

josuah

Hello all.
Some few practical details which you might be interested in before pursuing.

josuah · 2025-10-16T19:49:19Z

drivers/usb/uhc/uhc_renesas_ra.c

+	int ret;
+
+	ret = uhc_xfer_append(dev, xfer);
+	if (ret == 0) {
+		uhc_renesas_ra_xfer_request();
+	}
+
+	return ret;


While this is completely valid code, having the "success" exit of the function at the end helps with debugging (i.e. users trying to understand a bug they encounter).

How about flipping the ret == 0 for ret != 0 even if it uses one more line?

Suggested change

int ret;

ret = uhc_xfer_append(dev, xfer);

if (ret == 0) {

uhc_renesas_ra_xfer_request();

}

return ret;

int ret;

ret = uhc_xfer_append(dev, xfer);

if (ret != 0) {

return ret;

}

uhc_renesas_ra_xfer_request();

return 0;

josuah · 2025-10-16T22:13:41Z

drivers/usb/uhc/uhc_renesas_ra.c

+	if (priv->first_xfer != NULL) {
+		uhc_xfer_free(dev, priv->first_xfer);
+		priv->first_xfer = NULL;
+	}


Just wondering: is it required to also uhc_xfer_free(dev, priv->last_xfer);?
I did not follow the entire logic to be able to tell, so maybe this is not needed.

josuah · 2025-10-16T22:44:59Z

drivers/usb/uhc/uhc_renesas_ra.c

+{
+	struct uhc_renesas_ra_evt event = {.type = UHC_RENESAS_RA_EVT_XFER};
+
+	k_msgq_put(&uhc_msgq, &event, K_NO_WAIT);


If the event queue is full, this could fail as it is K_NO_WAIT, in particular under heavy load.

It could be interesting to add a LOG_WRN(), an __ASSERT_NO_MSG() or return the error, to help with troubleshooting.

josuah · 2025-10-16T22:45:33Z

drivers/usb/uhc/uhc_renesas_ra.c

+		.hal_evt = p_args->event,
+	};
+
+	k_msgq_put(&uhc_msgq, &event, K_NO_WAIT);


Here too in case that's something you wanted to check.

zephyrbot added manifest manifest-hal_renesas DNM This PR should not be merged (Do Not Merge) labels Dec 9, 2024

thenguyenyf force-pushed the support_renesas_ra_uhc branch 6 times, most recently from 9356bc5 to 68f0507 Compare December 23, 2024 03:07

thenguyenyf marked this pull request as ready for review December 23, 2024 04:28

zephyrbot added platform: Renesas RA Renesas Electronics Corporation, RA area: Samples Samples area: USB Universal Serial Bus labels Dec 23, 2024

zephyrbot requested review from KhiemNguyenT, duynguyenxa, jfischer-no, kartben, nashif, soburi, thaoluonguw and tmon-nordic December 23, 2024 04:29

zephyrbot assigned jfischer-no Dec 23, 2024

thenguyenyf force-pushed the support_renesas_ra_uhc branch from 68f0507 to 00f6cce Compare December 23, 2024 09:53

tmon-nordic previously approved these changes Jan 9, 2025

View reviewed changes

fabiobaltieri added DNM (manifest) This PR should not be merged (controlled by action-manifest) and removed DNM This PR should not be merged (Do Not Merge) labels Feb 4, 2025

facchinm mentioned this pull request Feb 6, 2025

boards: support Arduino Portenta C33 #85337

Merged

16 tasks

thenguyenyf dismissed tmon-nordic’s stale review via 3ce519d February 17, 2025 08:58

thenguyenyf force-pushed the support_renesas_ra_uhc branch from 00f6cce to 3ce519d Compare February 17, 2025 08:58

ArtemStGrTh reviewed Aug 24, 2025

View reviewed changes

drivers/usb/uhc/uhc_renesas_ra.c Outdated Show resolved Hide resolved

drivers/usb/uhc/uhc_renesas_ra.c Outdated Show resolved Hide resolved

thenguyenyf force-pushed the support_renesas_ra_uhc branch from a6ca200 to 02541db Compare August 25, 2025 06:28

zephyrbot requested a review from JarmouniA August 25, 2025 06:29

thenguyenyf force-pushed the support_renesas_ra_uhc branch from 02541db to 26c8de6 Compare August 25, 2025 06:52

ArtemStGrTh reviewed Aug 25, 2025

View reviewed changes

drivers/usb/uhc/uhc_renesas_ra.c Show resolved Hide resolved

thenguyenyf force-pushed the support_renesas_ra_uhc branch from 26c8de6 to 9c56d39 Compare September 23, 2025 15:45

zephyrbot requested a review from khoa-nguyen-18 September 23, 2025 15:46

thenguyenyf force-pushed the support_renesas_ra_uhc branch from 9c56d39 to 9a10f10 Compare September 23, 2025 16:07

jfischer-no reviewed Sep 25, 2025

View reviewed changes

jfischer-no requested review from josuah and removed request for JarmouniA and nashif September 25, 2025 19:49

thenguyenyf force-pushed the support_renesas_ra_uhc branch from 9a10f10 to dc43286 Compare September 26, 2025 02:46

zephyrbot requested review from JarmouniA and nashif September 26, 2025 02:48

Minh Hoang and others added 4 commits September 26, 2025 02:53

drivers: usb: uhc: add support for Renesas RA USB host

beda285

First commit to support UHC driver for Renesas RA family Signed-off-by: Minh Hoang <[email protected]> Signed-off-by: The Nguyen <[email protected]>

dts: arm: renesas: add support for UHC on Renesas RA SoCs

9ba0058

Add device node to support UHC on Renesas RA SoCs Signed-off-by: Minh Hoang <[email protected]> Signed-off-by: The Nguyen <[email protected]>

boards: renesas: add support for Renesas RA USB host

7196a7f

Enable USB host support on Renesas RA boards Signed-off-by: Minh Hoang <[email protected]> Signed-off-by: The Nguyen <[email protected]>

samples: subsys: usb: shell: add support for renesas,ra-uhc

6303874

Support USBH shell sample for renesas,ra-uhc Signed-off-by: The Nguyen <[email protected]>

thenguyenyf force-pushed the support_renesas_ra_uhc branch from dc43286 to 6303874 Compare September 26, 2025 02:55

thenguyenyf requested a review from jfischer-no September 26, 2025 04:05

josuah reviewed Oct 17, 2025

View reviewed changes

		struct uhc_renesas_ra_evt event = {.type = UHC_RENESAS_RA_EVT_HAL,
		.hal_evt = p_args->event};

		int err;

		err = R_USBH_XferStart(&priv->uhc_ctrl, xfer->udev->addr, xfer->ep, buffer_tail, len);

drivers: usb: uhc: initial support for UHC driver on Renesas RA family #82730

Are you sure you want to change the base?

drivers: usb: uhc: initial support for UHC driver on Renesas RA family #82730

Uh oh!

Conversation

thenguyenyf commented Dec 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zephyrbot commented Dec 9, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thenguyenyf commented Aug 25, 2025

Uh oh!

Uh oh!

thenguyenyf commented Sep 11, 2025

Uh oh!

jfischer-no commented Sep 23, 2025

Uh oh!

thenguyenyf commented Sep 23, 2025

Uh oh!

thenguyenyf commented Sep 23, 2025

Uh oh!

thenguyenyf commented Sep 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Sep 26, 2025

Quality Gate passed

Uh oh!

thenguyenyf commented Sep 29, 2025

Uh oh!

josuah left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

josuah Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

thenguyenyf commented Dec 9, 2024 •

edited

Loading

zephyrbot commented Dec 9, 2024 •

edited by github-actions bot

Loading

josuah Oct 16, 2025 •

edited

Loading