Bluetooth: Add missing includes #88528
Open
+699
−347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 64 out of 65 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- subsys/bluetooth/host/Kconfig: Language not supported
Comments suppressed due to low confidence (1)
include/zephyr/bluetooth/att.h:152
- Corrected a spelling typo in the parameter documentation: 'beares' changed to 'bearers'.
* @param num_channels The number of Enhanced ATT bearers to request.
github-actions
bot
added
area: Bluetooth ISO
github-actions
bot
requested review from
alwa-nordic,
cvinayak,
hermabe,
jhedberg,
rugeGerritsen,
sjanc and
theob-pro
jhedberg
reviewed
Apr 12, 2025
Thalley
force-pushed
the
bluetooth_includes
branch
from
abe60e4 to
7d0e763
Compare
jhedberg
previously approved these changes
Apr 13, 2025
alwa-nordic
previously approved these changes
Apr 14, 2025
Added missing includes and fixed typos in the header files for Bluetooth. There is one exception in hci_vs.h where `struct arch_esf` is still missing an include, but that is because that is only specific for ARM. Signed-off-by: Emil Gydesen <[email protected]>
Added missing includes and fixed typos in the files. Signed-off-by: Emil Gydesen <[email protected]>
Added missing includes and fixed typos in the files. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
bluetooth_includes
branch
from
7d0e763 to
4893895
Compare
|
Fixed merge conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing includes in all Bluetooth host files, as well as fixing some typos found during the same lookthrough.
The purpose of this is to help enforce IWYU (include what you use) and avoid any possible compilation issues if you include things in a way that hasn't been otherwise tested.
There were 2 circular dependencies found that should get fixed in a followed (see TODOs in the commits).