posix: options: add custom Zephyr POSIX subprofile #88547
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
add-zephyr-posix-aep-choice
branch
from
0d193e5 to
f68b0fb
Compare
|
Probably one or two follow-up PRs can be made to ensure that the Currently, all of the implementation of |
cfriedt
force-pushed
the
add-zephyr-posix-aep-choice
branch
3 times, most recently
from
c0f93e0 to
e891f53
Compare
The eventfd configuration does not need to be so deeply nested within POSIX since it does not depend on POSIX completely. Signed-off-by: Chris Friedt <[email protected]>
Separate the POSIX implementation into two categories: - Extensions to ISO C - System Interfaces The first category include standalone functions that generally do not require OS support or depend on any other features within the POSIX specification. The Option Groups that comprise this category include - POSIX_C_LIB_EXT: e.g. strnlen(), fnmatch() - POSIX_C_LANG_SUPPORT_R: e.g. gmtime_r(), strtok_r() The second category includes the majority of other POSIX Option Groups that do require OS support. The latter group may also be categorized generally as being NATIVE_LIBC_INCOMPATIBLE, although that might eventually become more granular. Signed-off-by: Chris Friedt <[email protected]>
Add a custom Zephyr POSIX subprofile specifically for enabling the default features that Zephyr requires as per the coding guidelines. Signed-off-by: Chris Friedt <[email protected]>
Default POSIX_AEP_CHOICE to POSIX_AEP_CHOICE_ZEPHYR Signed-off-by: Chris Friedt <[email protected]>
Add zephyr-keep-sorted-start and zephyr-keep-sorted-stop comments. Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
add-zephyr-posix-aep-choice
branch
from
e891f53 to
10c619d
Compare
This was referenced Apr 12, 2025
|
Shell utilities should probably also be gated by the new Kconfig. |
JordanYates
requested changes
Apr 14, 2025
| # POSIX System Interfaces | ||
| menuconfig POSIX_SYSTEM_INTERFACES | ||
| bool "POSIX System Interfaces" | ||
| depends on !NATIVE_APPLICATION |
There was a problem hiding this comment.
Something wrong with the indentation here
jukkar
reviewed
Apr 15, 2025
|
|
||
| These functions are divided into two standalone Option Groups that may be enabled | ||
| independently of the remainder of the POSIX API implementation; namely POSIX_C_LIB_EXT and | ||
| POSIX_C_LANG_SUPPORT_R. If not referenced by the Zephyr kernel or application, There are no |
There was a problem hiding this comment.
Suggested change
| POSIX_C_LANG_SUPPORT_R. If not referenced by the Zephyr kernel or application, There are no | |
| POSIX_C_LANG_SUPPORT_R. If not referenced by the Zephyr kernel or application, there are no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSIX_AEP_CHOICE_ZEPHYRthe defaultFixes #75843
Before:
wc -l build-main/zephyr/.config 1385 build-main/zephyr/.configAfter:
wc -l build-branch/zephyr/.config 1315 build-branch/zephyr/.config