-
Notifications
You must be signed in to change notification settings - Fork 8.1k
scripts: Don't use isort known-first-party #97693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: Don't use isort known-first-party #97693
Conversation
Partially revert 1bcc065 This change impacts all other scripts that import those modules, while those weren't updated. It will be hard to maintain this list, whilst keeping the entire tree compliant. Signed-off-by: Pieter De Gendt <[email protected]>
|
@pdgendt Does it fails on CI or just when you run ruff locally? I haven't seen any issues when I ran |
It didn't fail in CI because it only checks for changed files in a PR (will post updated check soon ASAP) EDIT: see #97700 |
Wouldn't it be easier to just fix those files, it's mostly just one blank line in imports? |
But the list you have added isn't complete, and it would be difficult to maintain such a specific list IMO. What do you think is the added value for having known first-party modules? Other than a separate import block? |
The main challenge is that the list of "known-first-party" is very incomplete, and very hard / impossible to maintain. |
One would know if a module/package is part of zephyr repo or it is third party package. But I understand it is hard to maintain due to technical debt and mess with python scripts in Zephyr. |
Partially revert 1bcc065
This change impacts all other scripts that import those modules, while those weren't updated.
It will be hard to maintain this list, whilst keeping the entire tree compliant.
Running the linter on the tree: