Add Explore Zero banner #665
Open
+113
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 build.zip [updated at Nov 20, 2:49:33 PM UTC] |
vyorkin
force-pushed
the
feature/zero-banner
branch
from
ffb01c0 to
b0a11e9
Compare
vyorkin
force-pushed
the
feature/zero-banner
branch
from
1ccb0c8 to
937ed7f
Compare
There was a problem hiding this comment.
| @@ -75,8 +76,16 @@ export function Banners({ address }: { address: string }) { | |||
| /> | |||
| <Spacer height={24} /> | |||
| </> | |||
| ) : null} | |||
| {ENABLE_DNA_BANNERS && !invitationBannerVisible ? ( | |||
| ) : !preferences?.exploreZeroBannerDismissed ? ( | |||
There was a problem hiding this comment.
I think it's possible to accidentally flash this banner before we show InviteFriendsBanner
Maybe we should bail out of everything while useRemoteConfigValue query is loading
zerts
reviewed
Dec 2, 2024
| .bannerLink { | ||
| display: block; | ||
| position: relative; | ||
| z-index: 1; |
There was a problem hiding this comment.
Looks like all elements have the same z-index. Do we need it?
zerts
reviewed
Dec 2, 2024
| /> | ||
| <Spacer height={24} /> | ||
| </> | ||
| ) : ENABLE_DNA_BANNERS ? ( |
There was a problem hiding this comment.
May be it will be the time to remove these dna banners soon.
I am pretty sure we will not return them, cause there is no more dna on Ethereum :))
|
It looks like the ZERO image is slightly bigger then in design and too close to the borders. But may be this is just me |
zerts
approved these changes
Dec 2, 2024
everdimension
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.