Create pending transaction state #710
Conversation
|
📦 build.zip [updated at Feb 18, 3:52:51 PM UTC] |
zerts
force-pushed
the
task/extension-show-tx-status-on-last-screen-of-native-flow-WLT-5816
branch
from
e80be16 to
946a303
Compare
| ? transactionReceiptToActionStatus({ receipt: ethersv5Receipt }) | ||
| : null; | ||
|
|
||
| return localStatus || nodeStatus || 'pending'; |
There was a problem hiding this comment.
Is it ok to use pending as a fallback option?
| import { sendRpcRequest } from 'src/shared/custom-rpc/rpc-request'; | ||
| import { wait } from 'src/shared/wait'; | ||
|
|
||
| export async function getTransactionReceipt({ |
There was a problem hiding this comment.
TransactionPoller is already performing this work
I think we should be able to tap into it from the UI
There was a problem hiding this comment.
I was thinking about this, but didn't get the easy solution. Will think again
| <UIText kind="headline/hero">{pendingTitle}</UIText> | ||
| <AnimatedDots /> | ||
| </HStack> | ||
| <UIText | ||
| kind="headline/hero" | ||
| className={cn( | ||
| styles.title, | ||
| status !== 'confirmed' && styles.hidden | ||
| )} | ||
| > | ||
| {confirmedTitle} | ||
| </UIText> |
There was a problem hiding this comment.
I know it's minor but I don't like that text selection is messed up in this area because of overlapping text elements with zero opacity
Can we fix this?
| <PageColumn | ||
| style={{ | ||
| width: 'clamp(320px, 100vw, 450px)', | ||
| marginInline: 'auto', | ||
| position: 'relative', | ||
| }} | ||
| > |
There was a problem hiding this comment.
What do you think about making this whole element appear with a quick fade-in? I think currently it feels a bit off that it appears kinda unexpectedly but then has fluid animations within
| return ( | ||
| <PageColumn> | ||
| <NavigationTitle urlBar="none" title="Send Success" /> |
| @@ -43,10 +56,12 @@ | |||
|
|
|||
| .title.hidden { | |||
| opacity: 0; | |||
| user-select: none; | |||
There was a problem hiding this comment.
Does this work? I'd think it should be pointer-events: none instead
There was a problem hiding this comment.
I thought, user-select is the one that should be used here. As it prevents text from being selected
I can change to pointer-events too. Not sure there is a difference in this case
There was a problem hiding this comment.
I meant that the visible text should still be selectable :)
No description provided.