Search page #834
Search page #834
Conversation
|
📦 build.zip [updated at Sep 5, 1:23:50 PM UTC] |
| position: 'relative', | ||
| left: -16, | ||
| width: 'calc(100% + 32px)', | ||
| overflow: 'hidden', |
There was a problem hiding this comment.
This fixes horizontal scroll appear because of the animated point on the chart
zerts
force-pushed
the
task/extension-add-search-in-extension-WLT-7063
branch
from
848567e to
eb17b98
Compare
src/background/Wallet/model/types.ts
Outdated
| configurableNonce?: boolean; | ||
| invitationBannerDismissed?: boolean; | ||
| recentAddresses?: string[]; | ||
| recentSearch?: string[]; |
There was a problem hiding this comment.
This shouldn't be part of wallet record; instead it should be a separate storage entry, like chain-configs
| onClick={() => { | ||
| walletPort.request('assetClicked', { | ||
| assetId: position.asset.id, | ||
| pathname, | ||
| section: 'Overview', | ||
| }); | ||
| }} |
There was a problem hiding this comment.
What if asset link is pressed using the keyboard?
Ideally "screen view" event should be enough for this. Maybe these links should have additional search params to let analytics know that they have been visited from search results.
There was a problem hiding this comment.
I believe this is an approach for analytics to track all usage of the search page.
However, the previous screen name really should be enough for this. I will ask about this.
zerts
force-pushed
the
task/extension-add-search-in-extension-WLT-7063
branch
from
5f77365 to
e37fd56
Compare
zerts
force-pushed
the
task/extension-add-search-in-extension-WLT-7063
branch
from
e37fd56 to
4c0b443
Compare
Uh oh!
There was an error while loading. Please reload this page.