Transaction batching + new History endpoint #843

zerts · 2025-08-15T22:14:33Z

In this PR new history endpoint is being introduced.

What was changed:

history requests in History and Asset pages -> ZPI
no more auto updates, refresh button and cmd+R were introduced
action details view moved from the dialog to the separate page, cause in the batched actions there will be nested views and page is a better approach. Action info is passed via the location state.
updated views for actions in history, asset page and action details page

In the nearest future transaction simulation will move to the new scheme, so all the places where we work with simulations were updated too

simulation view
action creation for analytics
updated logic for the edit approval form

Also with this update we are moving away from using asset implementations as much as possible.
For now we still need them for Send Form and Edit Approve Form, so there were added some extra logic to keep base quantity instead of common where it is needed.

Partially, simulations components were moved to networkConfig as a prop instead of fetching networks.

TODO

remove backend_env before release

Questions to discuss

Do we expect network to be non null during the transaction process? It looks like our UI will no allow to sign tx without the network configuration. Can we use this as invariant everywhere?

github-actions · 2025-08-15T22:16:11Z

📦 build.zip [updated at Oct 22, 10:48:00 AM UTC]

zerts · 2025-08-21T08:42:59Z

src/modules/ethereum/transactions/interpret.ts

+  action: AddressAction | null;
+};
+
+async function convertToNewInterpretation(


Temporary function until backend support new data scheme in the new ZPI endpoint

zerts · 2025-08-21T10:52:19Z

src/ui/pages/History/AccelerateTransactionDialog/shared/accelerate-helpers.test.ts

-
-invariant(testAddress, 'TEST_WALLET_ADDRESS Env var not found');
-
-const cancelTxSample = {


Do we need to recreate this test with the new scheme?

zerts · 2025-09-15T13:35:16Z

Do not forget to change backend_env back before release

everdimension · 2025-10-01T17:51:26Z

src/modules/ethereum/message-signing/prepareTypedData.ts

    try {
-      const typedData = JSON.parse(data);
+      const typedData = JSON.parse(data) as TypedData;
+      // Backend expect chainId to be a string


Suggested change

// Backend expect chainId to be a string

// Backend expects chainId to be a string

everdimension · 2025-10-01T17:52:32Z

src/modules/ethereum/message-signing/prepareTypedData.ts

+      // TODO: remove when backend fixed
+      typedData.domain.chainId = typedData.domain.chainId
+        ? String(typedData.domain.chainId)
+        : undefined;


remove?

this is safer:

Suggested change

// TODO: remove when backend fixed

typedData.domain.chainId = typedData.domain.chainId

? String(typedData.domain.chainId)

: undefined;

// TODO: remove when backend fixed

if (typedData.domain.chainId) {

typedData.domain.chainId = String(typedData.domain.chainId)

}

everdimension · 2025-10-03T11:31:18Z

src/ui/pages/ActionInfo/ActionInfo.tsx

+    'actIndex should be a number or be empty'
+  );
+  const actIndex = act_index ? Number(act_index) : undefined;
+  const addressAction = state.addressAction as AddressAction | undefined;


state is undefined on direct navigation, leading to crash

everdimension · 2025-10-03T11:32:16Z

src/modules/ethereum/message-signing/prepareTypedData.ts

  if (typeof data === 'string') {
    try {
-      const typedData = JSON.parse(data);
+      const typedData = JSON.parse(data) as TypedData;


The next line does the same casting. Is this necessary?

everdimension · 2025-10-03T13:03:55Z

src/ui/components/TiltCard/TiltCard.tsx

It's already in the main (🫠), so let's remove it at least here

everdimension · 2025-10-03T13:03:59Z

src/ui/components/TiltCard/index.ts

everdimension · 2025-10-03T13:04:03Z

src/ui/components/TiltCard/styles.module.css

everdimension · 2025-10-03T13:08:46Z

src/ui/components/address-action/AddressActionDetails/AddressActionDetails.tsx

+    if (
+      allowanceQuantityCommon == null ||
+      addressAction?.acts?.length !== 1 ||
+      addressAction.acts[0].content?.approvals?.length !== 1
+    ) {
+      return addressAction;
+    }
+    return produce(addressAction, (draft) => {
+      if (draft.acts?.[0].content?.approvals?.[0]) {
+        if (draft.acts[0].content.approvals[0].amount) {
+          draft.acts[0].content.approvals[0].amount.quantity =
+            allowanceQuantityCommon;
+        } else {
+          draft.acts[0].content.approvals[0].amount = {
+            quantity: allowanceQuantityCommon,
+            value: null,
+            usdValue: null,
+            currency: '',
+          };
+        }
+        if (customAllowanceQuantityBase != null) {
+          draft.acts[0].content.approvals[0].unlimited = isUnlimitedApproval(
+            customAllowanceQuantityBase
+          );
+        }
+      }
+    });


Maybe this logic is better placed outside of UI?
Perhaps in /src/modules/ethereum/transactions/appovals.ts? Or nearby:)

everdimension · 2025-10-03T13:14:29Z

src/ui/pages/ActionInfo/ActionInfo.tsx

+        <VStack gap={0}>
+          <UIText kind="headline/h3">{collection.name}</UIText>
+        </VStack>


is VStack needed?

everdimension · 2025-10-03T13:22:21Z

src/ui/pages/BridgeForm/BridgeForm.tsx

  );

+  // Special request for analytics purposes.
+  const { data: inputFungibleUsdInfo } = useAssetFullInfo(


Suggested change

const { data: inputFungibleUsdInfo } = useAssetFullInfo(

const { data: inputFungibleUsdInfoForAnalytics } = useAssetFullInfo(

everdimension · 2025-10-03T13:30:07Z

src/ui/pages/History/ActionsList/ActionsList.tsx

      </VStack>
      {actions.length && (isLoading || hasMore) ? (
        <SurfaceList
+          style={{ paddingBlockStart: 6, paddingBlockEnd: 6 }}


?

Suggested change

style={{ paddingBlockStart: 6, paddingBlockEnd: 6 }}

style={{ paddingBlock: 6 }}

everdimension · 2025-10-03T13:31:12Z

src/ui/pages/History/History.tsx

-  const backendHashes = new Set(backend.map((tx) => tx.transaction.hash));
+  const backendHashes = new Set(
+    backend.map(
+      (tx) => tx.transaction?.hash || tx.acts?.at(0)?.transaction.hash


Probably needs a comment. For now we can generate locally only txs with one hash, so it should be enough to compare the hash of the first act. But may be it is actually more reliable to go through all acts there

everdimension · 2025-10-03T13:34:11Z

src/ui/pages/History/History.tsx

+            />
+          </Button>
+          <KeyboardShortcut
+            combination="cmd+r"


Let's maybe mention this shortcut in the refresh button's title?

everdimension · 2025-10-03T13:36:40Z

src/ui/pages/SendForm/SendForm.tsx

  };

+  // Special request for analytics purposes.
+  const { data: inputFungibleUsdInfo } = useAssetFullInfo(


Suggested change

const { data: inputFungibleUsdInfo } = useAssetFullInfo(

const { data: inputFungibleUsdInfoForAnalytics } = useAssetFullInfo(

everdimension · 2025-10-03T13:40:38Z

src/ui/pages/SendTransaction/TransactionAdvancedView/TransactionAdvancedView.tsx

+  // const functionName = useMemo(
+  //   () =>
+  //     interpretation ? getInterpretationFunctionName(interpretation) : null,
+  //   [interpretation]
+  // );


rm comments in this file? Is this the final version?

Yes, I will remove comments!

everdimension · 2025-10-03T13:44:08Z

src/ui/pages/SwapForm/SwapForm.tsx

  useEffect(() => setAllowanceBase(null), [inputAmount, inputFungibleId]);

+  // Special request for analytics purposes.
+  const { data: inputFungibleUsdInfo } = useAssetFullInfo(


Suggested change

const { data: inputFungibleUsdInfo } = useAssetFullInfo(

const { data: inputFungibleUsdInfoForAnaytics } = useAssetFullInfo(

everdimension · 2025-10-03T13:47:52Z

src/ui/shared/requests/interpret.ts

+  { source }: BackendSourceParams
+): Promise<InterpretResponse | null> {
+  return Promise.race([
+    rejectAfterDelay(10000, 'interpret transaction'),


Why do we need a reject here? Http request should get rejected on its own?

Correct! That is the legacy from the socket api. Will remove!

everdimension · 2025-10-03T13:48:09Z

src/ui/shared/requests/interpret.ts

+  { source }: BackendSourceParams
+): Promise<SignatureInterpretResponse> {
+  return Promise.race([
+    rejectAfterDelay(10000, 'interpret signature'),


https://github.com/zeriontech/zerion-wallet-extension/pull/843/files#r2401987834

everdimension

See comments

zerts force-pushed the task/extension-support-transaction-batching-WLT-7704 branch from e5207a1 to 12540c3 Compare August 20, 2025 17:22

zerts commented Aug 21, 2025

View reviewed changes

zerts requested a review from everdimension August 26, 2025 14:13

zerts marked this pull request as ready for review August 26, 2025 14:13

zerts marked this pull request as draft September 5, 2025 13:34

zerts force-pushed the task/extension-support-transaction-batching-WLT-7704 branch from b7a7688 to 2e2a4f3 Compare September 11, 2025 13:26

zerts marked this pull request as ready for review September 15, 2025 13:35

zerts added 20 commits September 30, 2025 15:37

First iteration

a237ce4

Upate asset history general view

aa8afe8

Add detailed view

84ba81a

update action creators and refactor simulation view

cf547bf

add interpretation support

fa7c42d

merge local and backend actions

d198c52

fix custom approves

ca4eb4c

add update button

54f47c5

add disable for refresh button

6049144

fix loading jumos

3be3920

Fix style

13adae1

fix address line

97c5940

remove refetch on focus

a953216

update refetch logic

ec06bc4

rename back

f0a79b6

rename back 2

a919ef4

remove files

3b0a53b

rename 3

600c992

updates and refactors

fb9fb47

renames

bc1870c

zerts added 3 commits September 30, 2025 15:38

fix apply custom approval logic

45bb834

Fix typed data advanced view

809f447

fixes

d1d33e4

zerts force-pushed the task/extension-support-transaction-batching-WLT-7704 branch from 3cb877f to d1d33e4 Compare September 30, 2025 14:38

everdimension reviewed Oct 1, 2025

View reviewed changes

remove workaround

3d3845f

everdimension reviewed Oct 3, 2025

View reviewed changes

src/ui/components/TiltCard/index.ts

Copy link

Contributor

everdimension Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm?

everdimension reviewed Oct 3, 2025

View reviewed changes

src/ui/components/TiltCard/styles.module.css

Copy link

Contributor

everdimension Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm?

everdimension reviewed Oct 3, 2025

View reviewed changes

everdimension approved these changes Oct 3, 2025

View reviewed changes

zerts added 4 commits October 3, 2025 18:18

fixes for review comments

e095bfa

Fix Action NFT display

0b8ed95

add backend env back

3cfb6d8

revert backend_env

17b1761

zerts merged commit b5a6296 into main Oct 22, 2025
2 of 3 checks passed

zerts deleted the task/extension-support-transaction-batching-WLT-7704 branch October 22, 2025 10:48


		invariant(testAddress, 'TEST_WALLET_ADDRESS Env var not found');

		const cancelTxSample = {

	// Backend expect chainId to be a string
	// Backend expects chainId to be a string

	const { data: inputFungibleUsdInfo } = useAssetFullInfo(
	const { data: inputFungibleUsdInfoForAnalytics } = useAssetFullInfo(

	style={{ paddingBlockStart: 6, paddingBlockEnd: 6 }}
	style={{ paddingBlock: 6 }}

Transaction batching + new History endpoint #843

Transaction batching + new History endpoint #843

Uh oh!

Conversation

zerts commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What was changed:

TODO

Questions to discuss

Uh oh!

github-actions bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zerts Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zerts commented Sep 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

everdimension left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zerts commented Aug 15, 2025 •

edited

Loading

github-actions bot commented Aug 15, 2025 •

edited

Loading

zerts Aug 21, 2025 •

edited

Loading