-
Notifications
You must be signed in to change notification settings - Fork 44
Improve asset stats scroll #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve asset stats scroll #845
Conversation
src/ui/pages/AssetInfo/AssetInfo.tsx
Outdated
| premiumStatus={premiumStatus} | ||
| pnlIsSupported={!addrIsSolana} | ||
| /> | ||
| <VStack gap={8}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this to expand draggable area around the stats list.
|
📦 build.zip [updated at Sep 1, 2:28:19 PM UTC] |
| ref={containerRef} | ||
| gap={8} | ||
| className={styles.statsContainer} | ||
| style={{ paddingBlock: 16 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Padding to expand the draggable area
src/ui/ui-kit/HStack/HStack.tsx
Outdated
| /> | ||
| ); | ||
| }; | ||
| export const HStack = React.forwardRef< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change here is a wrap into forwardRef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why we need click-and-drag here
CSS scrolling solution should be enough
5181655 to
1a768e0
Compare
1a768e0 to
0d1f7ba
Compare
In this PR