Skip to content

Conversation

@DEmosus
Copy link
Member

@DEmosus DEmosus commented Oct 26, 2025

Thank you for making a pull request to ZTM's Animation Nation project. We will review your pull request as soon as we can, but keep in mind we can get very busy during Hacktoberfest.

While you're waiting, please look over this checklist. Feel free to write a description of what you did as well!

What I did

  • Added Newton’s Cosmic Cradle animation
  • Includes index.html, styles.css, and meta.json
  • Features:
    • Swinging Newton’s Cradle balls with left/right motion
    • Subtle vibration for the middle balls
    • Spark collision effects for added impact
    • A glowing coding joke caption with dual-color emphasis (green + purple)
  • All files are placed in the correct folder: Art/DEmosus-newtons-cradle/
  • Uses HTML + CSS only, no external assets or scripts

Pull request checklist

  • This pull request uses HTML and CSS only and provides a meta.json file.
  • All files in this pull request are in a directory named: <github_username>-<art_name> without the <>.
  • Your pull request contains index.html and styles.css.
    • Your html file is named exactly: index.html
    • Your css file is named exactly: styles.css
  • Your pull request your meta.json with:
    • githubHandle: being your unique github user name,
    • artName : name of your animation
  • Your submission includes at least one animation.
  • Your pull request does not modify any other files in the repository.

Not normally needed

  • Check this if you would like to discuss an improvement besides adding animations

Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section

What to expect

  • If your pull request meets the checklist requirements it will be approved and merged by a maintainer
  • If your pull request needs some changes. A maintainer will leave a comment requesting changes
  • If your pull request significantly violates the criteria in the checklist it will be closed with feedback.

@github-actions
Copy link

Aloha @DEmosus 🙌 - Thanks for your contribution!
Before we can merge your submission, please address the following points.

Feedback

Tip

You can refer to README.md for additional guidance.

  • CSS feedback for Art/DEmosus-newtons-cradle/styles.css
    • Incorrect animation trigger: remove any pseudo elements with your animation(s) and attach the animation to the concerned element

Happy Coding! 🚀

@github-actions
Copy link

Aloha @DEmosus 🙌 - Thanks for your contribution!
Before we can merge your submission, please address the following points.

Feedback

Tip

You can refer to README.md for additional guidance.

  • CSS feedback for Art/DEmosus-newtons-cradle/styles.css
    • Incorrect animation trigger: remove any pseudo elements with your animation(s) and attach the animation to the concerned element

Happy Coding! 🚀

@github-actions
Copy link

Aloha @DEmosus 🙌 - Thanks for your contribution!
Before we can merge your submission, please address the following points.

Feedback

Tip

You can refer to README.md for additional guidance.

  • CSS feedback for Art/DEmosus-newtons-cradle/styles.css
    • Incorrect animation trigger: remove any pseudo elements with your animation(s) and attach the animation to the concerned element

Happy Coding! 🚀

@LaurelineP LaurelineP assigned LaurelineP and DEmosus and unassigned LaurelineP Oct 26, 2025
@github-actions
Copy link

Aloha @DEmosus 🙌 - Thanks for your contribution!
Before we can merge your submission, please address the following points.

Feedback

Tip

You can refer to README.md for additional guidance.

  • CSS feedback for Art/DEmosus-newtons-cradle/styles.css
    • Incorrect animation trigger: remove any pseudo elements with your animation(s) and attach the animation to the concerned element

Happy Coding! 🚀

@github-actions
Copy link

Aloha @DEmosus 🙌 - Thanks for your contribution!
Before we can merge your submission, please address the following points.

Feedback

Tip

You can refer to README.md for additional guidance.

  • CSS feedback for Art/DEmosus-newtons-cradle/styles.css
    • Incorrect animation trigger: remove any pseudo elements with your animation(s) and attach the animation to the concerned element

Happy Coding! 🚀

@github-actions
Copy link

Aloha @DEmosus 🙌 - Thanks for your contribution!
Before we can merge your submission, please address the following points.

Feedback

Tip

You can refer to README.md for additional guidance.

  • CSS feedback for Art/DEmosus-newtons-cradle/styles.css
    • Incorrect animation trigger: remove any pseudo elements with your animation(s) and attach the animation to the concerned element

Happy Coding! 🚀

@DEmosus
Copy link
Member Author

DEmosus commented Oct 29, 2025

The bot is still flagging CSS feedback for Art/DEmosus-newtons-cradle/styles.css regarding an incorrect animation trigger: “remove any pseudo elements with your animation(s) and attach the animation to the concerned element.”

However, the animations are now applied directly to the .ball-wrapper elements, and no pseudo‑elements are being animated.

@LaurelineP
Copy link
Contributor

Aloha @DEmosus
The pseudo element here is still there in your file – this is why this does not pass the requirement and you have still the same feedback
image

@LaurelineP LaurelineP mentioned this pull request Oct 31, 2025
11 tasks
@LaurelineP LaurelineP closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants