Update index.html

[adarshh8]

Thank you for making a pull request to ZTM's Animation Nation project. We will review your pull request as soon as we can, but keep in mind we can get very busy during Hacktoberfest.

While you're waiting, please look over this checklist. Feel free to write a description of what you did as well!

What I did

Optional: Edit this to tell us what you did!

Pull request checklist

• This pull request uses HTML and CSS only and provides a meta.json file.
• All files in this pull request are in a directory named: <github_username>-<art_name> without the <>.
• Your pull request contains index.html and styles.css.
  • Your html file is named exactly: index.html
  • Your css file is named exactly: styles.css
• Your pull request your meta.json with:
  • githubHandle: being your unique github user name,
  • artName : name of your animation
• Your submission includes at least one animation.
• Your pull request does not modify any other files in the repository.

Not normally needed

• Check this if you would like to discuss an improvement besides adding animations

Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section

What to expect

• If your pull request meets the checklist requirements it will be approved and merged by a maintainer
• If your pull request needs some changes. A maintainer will leave a comment requesting changes
• If your pull request significantly violates the criteria in the checklist it will be closed with feedback.

[github-actions]

Aloha @adarshh8 🙌 - Thanks for your contribution!
Before we can merge your submission, please address the following points.

Feedback

Tip

You can refer to README.md for additional guidance.

• Overall feedback
  Reminder: the contribution should have 3 files in a folder in Art

  • Unauthorised changes:
    - please remove any changes in index.html

Happy Coding! 🚀

[LaurelineP]

PR Preview Changes

PR-overview_Adar-styling-changes.mp4

[LaurelineP]

Aloha @adarshh8 🙌 Thanks for the contribution.
Your changes are considered Out of scope based on the expected README.md animation guidelines.

We’ll double-check and discuss your PR, but when it comes to re-designing or restyling existing views, I’d strongly recommend opening a discussion first, as styling decisions are subjective.

Note

Most likely, this change won’t be accepted, but I’ll review it so you can learn from this experience. 🙂

🔸 Feedback & Tips

Tip

Always be aware of the current project organisation, how files are related and how the code works.

🔹 PR recommandations

Recommandations:

• When changing core parts of the project, it's best to:

• Describe exactly what you changed

• Explain why you've made these changes

• Pro tip (extra appreciated)
  Sharing visuals of your updates helps communicate changes quickly and provides context for reviewers.

Outcomes:

• Makes it easier for maintainers and reviewers to understand your PR without running the code
• Increases your chances of faster reviews and acceptance - especially when you are aware of the project's environment and structure.

🔹 Code & Technical feedback

Feedback you could address while we are discussing the PR.

Styles

• Please use public/styles.css to style the HTML
  You are currently adding / changing CSS in the HTML file while we have a public/styles.css file.
• WCAG - Accessibility regression for text contrast:
  We can see the background color change here is contrasted enough
  

[LaurelineP]

Aloha @adarshh8 🙌
Thank you again for your contribution and the time you put into this PR.

After discussing it, we won’t be able to accept this PR based on the previous points shared in the review discussion.

We truly appreciate your effort! The review notes should help guide future submissions, whether in this repo or another.
In the meantime, we'd love to review any other animation contributions you might have !

Happy coding to you !