Skip to content

Conversation

@ShubhamManglaw
Copy link

What I did

Updated the color scheme of the Animation Nation website to improve visual aesthetics and consistency:

  • Modified CSS color variables in styles.css:

    • Changed --main from #ffffff to #bdb6b6 for a softer, muted gray tone
    • Updated --main-deep from #f0f0f0 to #e8dddd for better color harmony
  • Enhanced header styling:

    • Updated the header title (#header h1) color to #b7bdbc for improved readability and a cohesive look with the overall color palette

These changes create a more refined and modern appearance while maintaining excellent readability and visual hierarchy.

Pull request checklist

  • This pull request uses HTML and CSS only and provides a meta.json file.
  • All files in this pull request are in a directory named: <github_username>-<art_name> without the <>.
  • Your pull request contains [index.html] and [styles.css].
    • Your html file is named exactly: [index.html]
    • Your css file is named exactly: [styles.css]

Not normally needed

  • Check this if you would like to discuss an improvement besides adding animations

Note: This pull request makes improvements to the existing color scheme rather than adding a new CSS animation. The changes enhance the visual design and user experience of the Animation Nation website by providing a more polished and cohesive color palette.

@github-actions
Copy link

Aloha @ShubhamManglaw 🙌 - Thanks for your contribution!
Before we can merge your submission, please address the following points.

Feedback

Tip

You can refer to README.md for additional guidance.

  • Overall feedback
    Reminder: the contribution should have 3 files in a folder in Art
    • Unauthorised changes:
      - please remove any changes in public/styles.css

Happy Coding! 🚀

@LaurelineP LaurelineP added the Out of scope For PR deliberately out of scope of contributions requested by README.md label Oct 27, 2025
Copy link
Contributor

@LaurelineP LaurelineP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aloha @ShubhamManglaw 🙌 Thanks for the contribution.
Your changes are considered Out of scope based on the expected README.md animation guidelines.

We’ll double-check and discuss your PR, but when it comes to re-designing or restyling existing views, I’d strongly recommend opening a discussion first, as styling decisions are subjective.

Note

Most likely, this change won’t be accepted, but I’ll review it so you can learn from this experience. 🙂

🔸 Feedback & Tips

Tip

Always be aware of the current project organisation, how files are related and how the code works.

🔹 PR recommandations

Recommandations:

  • Pro tip (extra appreciated)
    Sharing visuals of your updates helps communicate changes quickly and provides context for reviewers.

Outcomes:

  • Makes it easier for maintainers and reviewers to understand your PR without running the code
  • Increases your chances of faster reviews and acceptance - especially when you are aware of the project's environment and structure.

🔹 UI Feedback / Observations

image - there are visual / styling regressions changes in the card styles. For examples e.g.: cards padding, larger preview icons and reduced card height - the new version uses brighter and bolder whites, which makes visual hierarchy harder to perceive Elements now compete equally for attention, reducing clarity and distinction
  • the original UI color palette has been removed, were removed, which affects the project’s cohesive visual style.

As mentioned, these types of design changes should ideally be discussed first.

@LaurelineP
Copy link
Contributor

Aloha @ShubhamManglaw 🙌
Thank you again for your contribution and the time you put into this PR.

After discussing it, we won’t be able to accept this PR based on the previous points shared in the review discussion.

We truly appreciate your effort! The review notes should help guide future submissions, whether in this repo or another.
In the meantime, we'd love to review any other animation contributions you might have ! 🚀

Happy coding to you !

@LaurelineP LaurelineP closed this Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes Requested Out of scope For PR deliberately out of scope of contributions requested by README.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants