Add Windows ping command in ZeroTier installation tutorial #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ZeroTier installation tutorial only mentioned the ping command for Linux and macOS, which is `ping -c 5 <ip>`. This caused confusion for Windows users. Changed the command to `ping -n 5 <ip>' for Windows, which is the correct syntax. Additionally, added the expected output of the Windows ping command to clarify the result for users.
Z-char
requested review from
laduke,
danitheturtle,
rcoder,
glimberg,
joseph-henry and
aaronjohnson
as code owners
glimberg
requested changes
Feb 6, 2025
|
|
|
See requested changes |
Fix typo of "explained".
glimberg
approved these changes
Feb 13, 2025
|
This will go out next time we deploy a docs site update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ZeroTier installation tutorial only mentioned the ping command for Linux and macOS, which is
ping -c 5 <ip>. This caused confusion for Windows users.Changed the command to `ping -n 5 ' for Windows, which is the correct syntax. Additionally, added the expected output of the Windows ping command to clarify the result for users.