Skip to content

Add idempotency check to LLVM installation script #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
+17 −4
Draft

Add idempotency check to LLVM installation script #4

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dddfd09
Initial plan
Copilot Dec 9, 2025
2af3c03
Fix LLVM being downloaded every time bootstrap runs
Copilot Dec 9, 2025
9060477
Improve LLVM installation check to verify all required tools
Copilot Dec 9, 2025
8e5a120
Eliminate code duplication in symlink creation
Copilot Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions script/install-llvm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,22 @@ cleanup()

trap cleanup EXIT

create_symlinks()
{
echo "Creating symlinks in /usr/local/bin..."
sudo ln -sf "${INSTALL_DIR}/bin/clang-format" "/usr/local/bin/clang-format-19"
sudo ln -sf "${INSTALL_DIR}/bin/clang-tidy" "/usr/local/bin/clang-tidy-19"
sudo ln -sf "${INSTALL_DIR}/bin/clang-apply-replacements" "/usr/local/bin/clang-apply-replacements-19"
}

# Check if LLVM is already installed
if [ -d "${INSTALL_DIR}" ] && [ -x "${INSTALL_DIR}/bin/clang-format" ] && [ -x "${INSTALL_DIR}/bin/clang-tidy" ] && [ -x "${INSTALL_DIR}/bin/clang-apply-replacements" ]; then
echo "LLVM ${LLVM_VERSION} is already installed at ${INSTALL_DIR}."
create_symlinks
echo "Done."
exit 0
fi

cd "${TEMP_DIR}"

echo "Downloading LLVM from ${LLVM_URL}..."
Expand All @@ -63,9 +79,6 @@ echo "Installing to ${INSTALL_DIR}..."
sudo mkdir -p /opt
sudo mv "${LLVM_PACKAGE}" "${INSTALL_DIR}"

echo "Creating symlinks in /usr/local/bin..."
sudo ln -sf "${INSTALL_DIR}/bin/clang-format" "/usr/local/bin/clang-format-19"
sudo ln -sf "${INSTALL_DIR}/bin/clang-tidy" "/usr/local/bin/clang-tidy-19"
sudo ln -sf "${INSTALL_DIR}/bin/clang-apply-replacements" "/usr/local/bin/clang-apply-replacements-19"
create_symlinks

echo "Done."