Skip to content

Fix invalid session regeneration on wrong session ID #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fredericgboutin-yapla wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix invalid session regeneration on wrong session ID #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/zend-session/library/Zend/Session.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ public static function start($options = false)
// Generate a valid, temporary replacement
self::setId(md5(self::getId()));
// Force a regenerate after session is started
self::$_regenerateIdState = -1;
self::regenerateId();
}

if (self::$_sessionStarted && self::$_destroyed) {
Expand Down Expand Up @@ -459,7 +459,7 @@ public static function start($options = false)
}

// See http://www.php.net/manual/en/ref.session.php for explanation
if (!self::$_unitTestEnabled && defined('SID')) {
if (!self::$_unitTestEnabled && defined('SID') && SID !== '') {
Copy link
Contributor Author

@fredericgboutin-yapla fredericgboutin-yapla Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this condition is adding to the difficulty to properly unit-test

/** @see Zend_Session_Exception */
// require_once 'Zend/Session/Exception.php';
throw new Zend_Session_Exception('session has already been started by session.auto-start or session_start()');
Expand Down Expand Up @@ -662,7 +662,7 @@ public static function getId()
*/
public static function setId($id)
{
if (!self::$_unitTestEnabled && defined('SID')) {
if (!self::$_unitTestEnabled && defined('SID') && SID !== '') {
/** @see Zend_Session_Exception */
// require_once 'Zend/Session/Exception.php';
throw new Zend_Session_Exception('The session has already been started. The session id must be set first.');
Expand Down