IMPALA-12312: Planner chooes correct executor group set for planning#6
Open
zhangyifan27 wants to merge 1 commit intomasterfrom
Open
IMPALA-12312: Planner chooes correct executor group set for planning#6zhangyifan27 wants to merge 1 commit intomasterfrom
zhangyifan27 wants to merge 1 commit intomasterfrom
Conversation
zhangyifan27
force-pushed
the
IMPALA-12312
branch
from
780c064 to
e01e561
Compare
zhangyifan27
force-pushed
the
IMPALA-12312
branch
from
e01e561 to
a4910af
Compare
zhangyifan27
force-pushed
the
IMPALA-12312
branch
4 times, most recently
from
cc36a7a to
361fa6a
Compare
Prior to this patch, planner always selects the default group if there is a default group in an impala cluster. When a client sets a non-default request pool, planner still assumes the query run on the default group and calculates the wrong number of nodes and instances. This patch fixes it by including both default and non-default groups in the update message sent from BE to FE, so planner can generate a plan based on correct executor group set info. Besides, if no matched executor group is found, planner falls back to using the default group for planning, which is consistent with BE's behavior in GetExecutorGroupsForQuery. Tests: - Add new test cases to ClusterMembershipMgrUnitTest. - Add e2e test to verify the new behavior of planner. Change-Id: Ia13fb40558441d4dcc0b3e7910d3746bb61e6b80
zhangyifan27
force-pushed
the
IMPALA-12312
branch
from
361fa6a to
8621aac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this patch, planner always selects the default group if there is a default group in an impala cluster. When a client sets a non-default request pool, planner still assumes the query run on the default group and calculates the wrong number of nodes and instances.
This patch fixes it by including both default and non-default groups in the update message sent from BE to FE, so planner can generate a plan based on correct executor group set info. Besides, if no matched executor group is found, planner falls back to using the default group for planning, which is consistent with BE's behavior in GetExecutorGroupsForQuery.
Testing: