-
Notifications
You must be signed in to change notification settings - Fork 39
Replacing imgui to c homemade wrapper by cimgui #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I'm tired...
there muse be a lot of problem now but it requires test. it's also way faster
I believe this branch is now in a usable state. Also, this branch now uses imgui 1.92.1 which is what #51 is doing as well. Maybe @kcbanner you could give me your opinion? Currently, I haven't really added any new features of this imgui versions. So your input would be great. I also added some zig 0.5.1 compatibility that was probably forgotten. |
As previously discussed on discord, switching to using cimgui instead of wrapping every function of imgui manually might be a good idea.
By doing so, updating to the last imgui version should only be a matter of updating the commit hash in build.zig.zon while every single method is already wrapped and can be exposed to the users that would need really specific needs without having to make a pr.
Currently, this PR is not in a usable state at all. I put it here as a WIP (it compiles tho) so that if people want to have a look and give opinions they are welcome to do so.
My current thought is, to go in two steps to avoid defacing the whole project.
Any comments are welcome. I'll work on that at my own pace, as I might not have so much time.