add fn UdpConnectToAddress #25615
Open
add fn UdpConnectToAddress #25615
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalaxyShard
reviewed
Oct 17, 2025
lib/std/net.zig
Outdated
Comment on lines
860
to
861
| const winFlag = (if (native_os == .windows) 0 else posix.SOCK.CLOEXEC); | ||
| const sock_flags = posix.SOCK.DGRAM | nonblock | winFlag; |
There was a problem hiding this comment.
Zig prefers snake_case for variable names (win_flag, not winFlag).
winFlag is also not a great name, considering its a flag that is applied to non-windows systems.
SOCK.STREAM shouldn't have been changed to SOCK.DGRAM; this is TCP.
|
|
||
| pub const UdpConnectToAddressError = posix.SocketError || posix.ConnectError; | ||
|
|
||
| pub fn udpConnectToAddress(address: Address) UdpConnectToAddressError!Stream { |
There was a problem hiding this comment.
UDP is connectionless so it doesn't make sense to connect via UDP. Returning a stream also doesn't make sense, as UDP transmits individual datagrams and not a continuous stream of data.
Corrected the variable naming conventions, but currently using the same stream structure for UDP and TCP is out of necessity.
|
Fairly certain that std.net is being entirely deleted by #25592. |
|
@drunderscore But that might be a relatively distant matter, at least it seems so for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and Restructured the code layout of winflag to achieve a more coherent logical flow.