std.Target: add tags and info for alpha, hppa, microblaze, sh + some bonus commits
#25640
+1,032
−277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
force-pushed
the
std-target-more-arches
branch
from
ad038b3 to
fa70110
Compare
alexrp
commented
Oct 20, 2025
| else => VaListPowerPc, | ||
| }, | ||
| .s390x => VaListS390x, | ||
| .sh, .sheb => VaListSh, // TODO: This is wrong for `sh_renesas`. |
There was a problem hiding this comment.
@mlugg thoughts on this? GCC makes the definition of the type dependent on the enclosing function's calling convention, which seems clearly sensible to me. The idea that there is a single global VaList type is just kinda fundamentally flawed in a world where we support multiple calling conventions for one target.
I figure we could remove std.builtin.VaList and instead make Sema pick one of the more specific decls based on calling convention. It seems like moving that logic into the compiler will also let us get rid of a lot of special-casing we do around the resolution of VaList.
This was forgotten during the refactoring of std.builtin.CallingConvention. It mirrors mips64_n32 for MIPS.
The value being computed here is almost always equal to the pointer bit width.
These are microcontroller architectures; none of the OSs in the outer switch run on them.
alexrp
force-pushed
the
std-target-more-arches
branch
from
fa70110 to
09b53f7
Compare
Supported by LLVM and CBE.
Only supported in CBE.
Only supported in CBE.
This type has nothing to do with the language.
alexrp
force-pushed
the
std-target-more-arches
branch
from
09b53f7 to
c1100d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, we have target info for all architectures currently supported by Linux (except nios2, but that's at death's door anyway).