spir-v: Fix .storage_buffer pointer indexing #25641
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @alichraghi |
Renames arePointersLogical to shouldBlockPointerOps for clarity adds capability check to allow pointer ops on .storage_buffer when variable_pointers capability is enabled. Fixes ziglang#25638
alichraghi
approved these changes
Oct 20, 2025
| .global, .physical_storage_buffer => false, | ||
| // Logical pointers that support operations with VariablePointers capability | ||
| .shared => !target.cpu.features.isEnabled(@intFromEnum(std.Target.spirv.Feature.variable_pointers)), | ||
| //TODO: .storage_buffer is enabled by variable_pointers_storage_buffer once PR #24681 merges. |
There was a problem hiding this comment.
Please don't mention an unmerged PR in code. We will get a merge conflict anyway so no need to worry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames arePointersLogical to shouldBlockPointerOps for clarity.
Adds capability check to allow pointer operations on .storage_buffer when the variable_pointers capability is enabled.
This is a minimal change that fixes the immediate issue. Once PR #24681 merges, this should be updated to use variable_pointers_storage_buffer instead of variable_pointers for more fine-grained control.
Fixes #25638