Skip to content

Send three resets when connecting, not just one #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puddly merged 2 commits into from
Oct 7, 2025
Merged

Send three resets when connecting, not just one #689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f82dd07
Send three resets when connecting, not just one
puddly Oct 6, 2025
55c2009
Fix unit test
puddly Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bellows/ash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,4 +715,8 @@ async def send_data(self, data: bytes) -> None:
)

def send_reset(self) -> None:
# Some adapters seem to send a NAK immediately but still process the reset frame
# if one eventually makes it through
self._write_frame(RstFrame(), prefix=(Reserved.CANCEL,))
self._write_frame(RstFrame(), prefix=(Reserved.CANCEL,))
self._write_frame(RstFrame(), prefix=(Reserved.CANCEL,))
5 changes: 4 additions & 1 deletion tests/test_ash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,10 @@ async def test_ash_protocol_startup(caplog):

assert ezsp.reset_received.mock_calls == [call(t.NcpResetCode.RESET_SOFTWARE)]
assert protocol._write_frame.mock_calls == [
call(ash.RstFrame(), prefix=(ash.Reserved.CANCEL,))
# We send three
call(ash.RstFrame(), prefix=(ash.Reserved.CANCEL,)),
call(ash.RstFrame(), prefix=(ash.Reserved.CANCEL,)),
call(ash.RstFrame(), prefix=(ash.Reserved.CANCEL,)),
]

protocol._write_frame.reset_mock()
Expand Down
Loading