-
Notifications
You must be signed in to change notification settings - Fork 924
Add Linxura Aura Smart Button support 12 buttons and battery report. #4490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xiaodah123
wants to merge
95
commits into
zigpy:dev
Choose a base branch
from
xiaodah123:linxura_zigbee_ha
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+217
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linxura smart controller's Zigbee mode support four buttons. Each button support click, double click, long press actions.
modify spell issue
Co-authored-by: TheJulianJES <[email protected]>
1.Modify Aura Smart Button from 4 buttons to 12 buttons 2.Add Aura Smart Button for Battery Remaining Report.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4490 +/- ##
==========================================
+ Coverage 92.24% 92.26% +0.02%
==========================================
Files 369 369
Lines 12094 12127 +33
==========================================
+ Hits 11156 11189 +33
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Looking forward to your review and reply! |
Contributor
|
@TheJulianJES Hi, Is there anything I need to do before merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Additional information
Device diagnostics
Checklist
pre-commitchecks pass / the code has been formatted using Black