Add HOBEIAN ZG-303Z #4510
Open
Add HOBEIAN ZG-303Z #4510
+259
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4510 +/- ##
=======================================
Coverage 92.24% 92.25%
=======================================
Files 369 370 +1
Lines 12094 12109 +15
=======================================
+ Hits 11156 11171 +15
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The HOBEIAN ZG-303Z quirk now uses endpoints 2 and 3 for Soil Moisture (DP 3) and Relative Humidity (DP 109), respectively. This prevents values from being overwritten when they are reported simultaneously by the device, ensuring stable readings for both attributes.
Author
|
@TheJulianJES this is ready to go. I've looked at what is needed to enhance the V2 API to do the same thing and it doesn't look trivial. I suggest we do it in a second pass. |
|
So far (few hours) this works way better than previous ones, though it would be nice to re-add the low moisture warning and configuration/calibration endpoints - it could be a followup though to get this merged sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This allows soil moisture and humidity to both been seen. Previously, only temperature, soil moisture, and battery were shown. Even worse, soil moisture was incorrectly displayed as humidity due to it being reported under cluster 0x405.
Additional information
Other attempts to add support via the
TuyaQuirkBuilderdid not work because of how soil moisture would overwrite the humidity since they all shared the same endpoint. This quirk now uses endpoints 2 and 3 for Soil Moisture (DP 3) and Relative Humidity (DP 109), respectively. This prevents values from being overwritten when they are reported simultaneously by the device, ensuring stable readings for both attributes. We also drop the 0x405 cluster that was incorrectly reporting soil as humidity.Device diagnostics
zha-01K8BQMJSKZFPA3YC43C2Q4TB0-HOBEIAN ZG-303Z-8ec34d4e404ba4a5f4ec9dcf4bc9e3c8-2.json
Checklist
pre-commitchecks pass / the code has been formatted using Black