Merged
Conversation
sam-cw
force-pushed
the
improvement/ruby-4-upgrade
branch
3 times, most recently
from
567f584 to
82e52bb
Compare
sam-cw
force-pushed
the
improvement/ruby-4-upgrade
branch
from
82e52bb to
63b3e64
Compare
Since there don't seem to be any breaking changes we can still allow older ruby versions, so no need to increase the required ruby version. Active record 8.1 has removed and changed the behaviour of type_cast and related methods that Sequent relies on in the postgres persistor, so I have added that restriction to the gemspec as well.
sam-cw
force-pushed
the
improvement/ruby-4-upgrade
branch
from
63b3e64 to
501da64
Compare
Previously we relied on lookup_cast_type_from_column in the optimized postgres persistor, but that method has been deprecated without replacement. Since we used that to get the logical value from the database we can instead ask the class for the active support type for the column in question, and then ask it to serialize the value - as I understand it this leads to an equivalent value as the prior approach which can then be type cast as before.
Resolve issues with active record 8.1 support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there don't seem to be any breaking changes we can still allow older ruby versions, so no need to increase the required ruby version.
Active record 8.1 has removed and changed the behaviour of type_cast and related methods that Sequent relies on in the postgres persistor, so I have added that restriction to the gemspec as well.