ci: test against Ruby 3.3 #528
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#500 seems reasonable |
- Add webrick and rackup gems for Ruby 3.3 server support - Configure Capybara to use WEBrick with proper keyword arguments - Add response_body_formatter to handle binary data correctly - Improve StubApp request body parsing for different client types - Make OpenApi::Node settings method public for test access - Fix request body rewind compatibility across Rack versions
- Filter HTTP_VERSION header in env_to_headers (Rack 2.1.0 compatibility) - Add proper response body encoding handling for ASCII-8BIT content - Fix ApiFormatter event registration and notification handling - Update pending test to work with RSpec 3.13 behavior - Remove Sinatra dependency from test files (incompatible with Rack 2.1.0)
- Complete conversion of StubApp from Sinatra to plain Rack app - Fix response_body_formatter to return proper format for binary data - Update test configuration to use StubApp instances
Use anonymous classes instead of RSpec::Core::ExampleGroup.describe() to create example groups for formatter testing. This prevents RSpec 3.5+ from automatically registering and executing these test groups, which was causing false test failures.
Changed sinatra dependency from unversioned to "~> 2.0" to ensure compatibility with Rack 2.1.0. Sinatra 1.x requires Rack ~> 1.5 which conflicts with Rack 2.1.0, causing cucumber tests to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #515
There are failing tests in here which anyone should feel free to make a PR to address