Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for working hours #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

montan3ro
Copy link
Contributor

I'm not sure that using closures suits the existing style, but it seemed the best way to avoid adding complexity to the code. I thought at the least you might find the rest of it handy.

@zjfjack
Copy link
Owner

zjfjack commented Oct 29, 2018

Hi, montan3ro.

I appreciate your help for my project. I kinda understand your idea.
However, I don't think this case is necessary for a calendar.
In my todo list, I want to do something familiar to your case, which is setting the background color for the calendar week view.

For example, if someone wants Monday, Wednesday, Friday to be blue, but weekends are red. How can your solution solve this case?

Do you have any good ideas? We can discuss here, but I am quite busy these days, don't have enough time to code those stuff for you, since that one is not easy to implement if efficiency will be considered.

Thanks,
Jeff

@montan3ro
Copy link
Contributor Author

Hi zjfjack,

This was something that was required for my project. Many calendars support this functionality, such as Google and Outlook:

https://support.google.com/calendar/answer/7638168?hl=en
https://support.office.com/en-us/article/change-your-work-hours-and-days-in-outlook-a27f261d-0681-415f-8ac1-388ab21e833f

If you don't wish to have this in the main repo then that's fine - I can keep pointing to my own fork.

If you wanted to colour each day differently then maybe this would need to be a more generic functionality with no reference to working hours.

@zjfjack
Copy link
Owner

zjfjack commented Oct 30, 2018

Hi montan3ro,

Thanks for providing me those links. I love this feature.
But as I mentioned before, I prefer your idea to make it more generic way, then we can define a working hours helper to make users to utilise it. What do you think of it?

Thanks,
Jeff

@montan3ro
Copy link
Contributor Author

Hi Jeff,

That sounds like it would work. Unfortunately I don't have time at the moment to make the necessary changes, but perhaps I will revisit this some time in the future.

Thanks!
Stefan

@zjfjack
Copy link
Owner

zjfjack commented Oct 30, 2018

Yeah, that's what I am thinking. Maybe we can do it later, I don't have time currently too.
Will let you know if I start working on this. Thanks for helping me.

Regards,
Jeff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants