Upgrade to bevy 0.14.0 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that 0.14 is out, maintainer please evaluate and release 🙏🏼 |
zkat
approved these changes
Jul 9, 2024
zkat
pushed a commit
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the changes that were required for the 0.14.0
https://bevyengine.org/learn/migration-guides/0-13-to-0-14/#make-appexit-more-specific-about-exit-reason
https://bevyengine.org/learn/migration-guides/0-13-to-0-14/#overhaul-color
https://bevyengine.org/learn/migration-guides/0-13-to-0-14/#moves-intern-and-label-modules-into-bevy-ecs
https://bevyengine.org/learn/migration-guides/0-13-to-0-14/#improve-tracing-layer-customization
The only change I'm skeptical of is the AppExit::Success. Now that I'm looking at it, I'm guessing the logic is saying, we should never hit that condition and thus we're gonna hard exit. So it'd be an error
More importantly, I've removed bevy-scene-hook as a dependency. I haven't seen the contributor active in a while and the code to replace it was small enough with the new native observer APIs.