Add concurrent mode: any success #67
Conversation
| @@ -323,6 +323,7 @@ pub fn steps_system( | |||
| */ | |||
| #[derive(Debug)] | |||
| pub struct ConcurrentlyBuilder { | |||
| mode: ConcurrentMode, | |||
There was a problem hiding this comment.
I think my preference here would be to add a new Action instead, called Race, which is what this kind of operation is usually called, ime, as opposed to parameterizing Concurrently. Although if we're gonna go that way, maybe Concurrently should be renamed to Join, too...
There was a problem hiding this comment.
ah interesting. Where do you get those names from? Do you have a resource about utilityAI?
I wanted to re-use Concurrently because there's a lot of common code, but i can also split them up, and try to share code between the 2 actions, with a ConcurrentAction trait
There was a problem hiding this comment.
this naming is more from the world of threading/async :)
I like splitting them up even with that duplication because it's nicer to have individual but very simple building blocks, rather than increasingly parameterizing the same thing to tbh completely change their semantics.
Maybe some of the common logic can be moved to utility functions?
There was a problem hiding this comment.
I split up between Race and Join, removed Concurrently from the prelude, and added a cool little example that show clearly how Race and Join work :)
| name = "thirst" | ||
|
|
||
| [[example]] | ||
| name = "concurrent" |
There was a problem hiding this comment.
why are we listing examples explicitly?
There was a problem hiding this comment.
Not 100% sure if it's required, but it was to make sure that the examples use dev-dependencies. (https://doc.rust-lang.org/rust-by-example/testing/dev_dependencies.html)
In particular my concurrent example needs rand
|
Closing in favor of #68 |
|
Hi, you didn't want to include the example? I thought it could be helpful to illustrate the types of concurrency. |
|
oh!!! I totally forgot to move that over too. Sorry, yes. The example would be good (although since I didn't keep Join/Race (sorry, I know), that'll need to be adapted. Do you want to PR it or would you rather I do it? |
|
I'll let you do the adaptation if that's ok? |
|
yeah that's totally fine. I'll take care of it. :) |
Hi,
I wanted to have an Action that executes multiple actions concurrently, and succeeds when any of them works.
I tested it locally, works well :)
Added an example as well.