Add set_unchecked method to Score #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
reviewed
Jun 29, 2023
src/scorers.rs
Outdated
| @@ -35,6 +35,12 @@ impl Score { | |||
| } | |||
| self.0 = value; | |||
| } | |||
|
|
|||
| /// Set the `Score`'s value. Allows values outside the range `0.0..=1.0` | |||
| /// Note: it is up to you to make sure your scorers are using the same units! | |||
There was a problem hiding this comment.
I'd like a bit more of a warning here about the implications: It can make scorers much, much harder to effectively compose together when there isn't a single set scale.
zkat
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it can be useful to be able to represent scores outside the [0,1] range, especially when it is difficult to calculate the minimum and maximum values of a Scorer, or you want one scorer to be able to dominate in certain scenarios. This PR adds a
set_uncheckedmethod to Score to accommodate this.I saw some previous discussion on this in #36 , but I think it's good to give people the option. I've only been using big-brain for a few days, so feel free to ignore my opinion.