feat: allow for Name overrides in key picker #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the one you actually want has a symbol in the editor and the name tweaked - the one you probably don't want has a name change to hopefully show that it's not expected.
- Backspace is by far the more common search term and will now show this key (rather than just the keypad one)
✅ Deploy Preview for zmk-studio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Author
|
(Also would solve #96 ) |
BafS
suggested changes
Apr 12, 2025
| "38": { "short": "9" }, | ||
| "39": { "short": "0" }, | ||
| "40": { "short": "Ret", "med": "Return" }, | ||
| "38": { "short": "9", "Name":"Keyboard 9 and Left Parenthesis"}, |
There was a problem hiding this comment.
Suggested change
| "38": { "short": "9", "Name":"Keyboard 9 and Left Parenthesis"}, | |
| "38": { "short": "9", "name":"Keyboard 9 and Left Parenthesis" }, |
To keep the conventions
Author
There was a problem hiding this comment.
Yep, makes sense - i'll add it as a TODO for myself if the PR gets up - good spot!
BafS
reviewed
Apr 12, 2025
| "177": { "short": "000" }, | ||
| "224": { "short": "Ctrl", "med": "L Ctrl" }, | ||
| "225": { "short": "Shft", "med": "L Shft", "long": "L Shift" }, | ||
| "225": { "short": "⇧Shft", "med": "L Shft", "long": "L Shift" }, |
There was a problem hiding this comment.
I think it could make sense to have another section for icons, it would be more flexible, like that it would also be possible to switch depending the OS (typically GUI is quite different).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code change here is specifically to allow for overrides to be specified that would affect the display in the key picker - this duplicates (and would obsolete) #101, and fixes #100
In tracing through to make sure I understood the override system I also noticed that there was both
hid_usage_get_labelsandhid_usage_get_label- the singular function didn't appear to be used anywhere and had led me down a slightly wrong route when I was doing an initial read so have removed it.The last four commits are override updates I'm proposing:
Disclosure: wasn't sure best way to validate the changes/test and I've just been running a local loop with
npm run devso if there's a better way let me know.