-
-
Notifications
You must be signed in to change notification settings - Fork 82
Grid Picker for HID Usage #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Grid Picker for HID Usage #159
Conversation
✅ Deploy Preview for zmk-studio ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Example.mp4 |
650ddf2 to
b685fc4
Compare
|
Are you putting ISO keys like non-us-pound and non-us-backslash on basic? |
|
NUHS and NUBS are both under the ISO/JIS section at the moment |
|
Ah - a little cryptic so I missed them, but that's good. Thanks! |
b685fc4 to
8bc19a5
Compare
|
Would "International" be a better name for "ISO/JIS"? |
|
Show "Key Press" in a virtual keyboard may be better, like https://hodgef.com/simple-keyboard/demos/?d=fullKeyboard. That's what I did in my fork, and it works very well. |
5e0bb15 to
af6c818
Compare
I think this could be a good improvement - but I don't want to add too much into this PR. Right now, it's pretty easy to digest, but with the special-casing dropdown for the "Other" category, it's already a bit messier than I had hoped. IMO - we should consider this in a subsequent PR. I think this one already moves the experience forward incrementally, and that would be a good incremental change on top of this. |
This changes the HidUsagePicker to a grid-of-buttons style of input, similar to what we see in VIA or VIAL.
We keep the modifier toggles so people can still add modifiers to their keys too.
Some decisions I made:
Some things I need help with: