Incorporating polarization conventions#97
Open
krishnatejavedula wants to merge 2 commits intozoglauer:mainfrom
Open
Incorporating polarization conventions#97krishnatejavedula wants to merge 2 commits intozoglauer:mainfrom
krishnatejavedula wants to merge 2 commits intozoglauer:mainfrom
Conversation
…iles by adding the functions related to orthographic and stereographic polarization conventions
GallegoSav
reviewed
Sep 26, 2024
|
|
||
|
|
||
| // Constants for angle normalization | ||
| const double PI = 3.14159265358979323846; |
There was a problem hiding this comment.
you can use c_Pi for pi ni the code
Owner
|
Yes. Use c_Pi
…On 9/26/24 2:34 PM, GallegoSav wrote:
***@***.**** commented on this pull request.
------------------------------------------------------------------------
In src/cosima/src/MCSource.cc <https://github.com/zoglauer/megalib/
pull/97#discussion_r1777756596>:
> @@ -3626,6 +3626,104 @@ double MCSource::Comptonized(const double Energy, double Alpha, double Epeak) co
return pow(Energy, Alpha)*exp(-(Alpha+2)*Energy/Epeak);
}
+/******************************************************************************
+
+* Polarization conventions
+*/
+
+
+// Constants for angle normalization
+const double PI = 3.14159265358979323846;
you can use c_Pi for pi ni the code
—
Reply to this email directly, view it on GitHub <https://github.com/
zoglauer/megalib#97#pullrequestreview-2332382843>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/
ABBIYWAXKYPLJDBJJVO2OITZYR4WVAVCNFSM6AAAAABODHP7F6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMZSGM4DEOBUGM>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the cosima/src/MCSource.cc file and cosima/inc/MCSource.hh files by adding the functions related to orthographic and stereographic polarization conventions