Repository navigation
fix: list commands fetch every page by default - #8
Merged
Merged
Conversation
Six list commands (zone/record/tsig/messages/report problematic-zones/ acme list-challenges) previously truncated at the first API page (50 rows, 100 for ACME) with exit code 0 and no warning. A zone with 50 RRsets and a zone with thousands looked identical on screen, which caused an operational incident where records were declared absent because they had been silently paginated off the first page. Default behavior now fetches every page. `--all` is kept as an accepted no-op for script compatibility. `--page N` remains the explicit single-page path and now prints a stderr warning when more rows exist (envelope shape) or may exist (bare-array shape); `-q` / `--quiet` suppresses it. JSON/YAML stdout stays clean — warnings are stderr-only. Adds `PageInfo` + `fetch_page()` to the paginator for the single-page path, `_warn_if_truncated()` helper in commands, and 15 new tests (9 integration regressions + 6 paginator unit tests). Rewrites the pagination topic doc.
zoltanf
force-pushed
the
fix/list-default-fetch-all
branch
from
April 24, 2026 20:55
17e637e to
17929da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a silent-truncation failure mode in six list commands.
rc0 record list <zone>(and five siblings) previously returned only the first API page — 50 rows, 100 for ACME — with exit code 0 and no stderr indication that more results existed. A zone with 50 RRsets and a zone with thousands looked identical on screen, which caused an operational incident where records were declared absent because they had been silently paginated off the first page.zone list,record list,tsig list,messages list,report problematic-zones,acme list-challenges.--allstays accepted as a no-op for script compatibility (help text updated).--page Nstays explicit and now prints a stderr warning when more rows exist (envelope shape) or may exist (bare-array shape).-q/--quietsuppresses it. JSON/YAML stdout remains clean.--all+--pagestill a hard error (exit 7).Adds
PageInfo+fetch_page()to the paginator,_warn_if_truncated()helper, 9 new integration regression tests, 6 new paginator unit tests. Rewrites thepaginationhelp topic.Per release convention, no version bump in this PR —
scripts/release.sh 1.1.0after merge handlespyproject.toml,__init__.py, and the dated CHANGELOG heading.Test plan
uv run ruff check .— cleanuv run ruff format --check .— cleanuv run mypy— 71 source files, no issuesuv run pytest— 431 passed, coverage 91.24% (floor 88)