Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renewed ZMI #20

Merged
merged 6 commits into from
Jul 13, 2020
Merged

Renewed ZMI #20

merged 6 commits into from
Jul 13, 2020

Conversation

drfho
Copy link
Contributor

@drfho drfho commented Jul 13, 2020 •
edited
Loading

Hello @dataflake ,
i refreshed the ZMI according to Zope4 Styles and used svg icons instead of gif.

Products ZMySQLDA_GUI

The code diff you can see here:
https://github.com/zms-publishing/Products.ZMySQLDA/compare/zmi4

I left the gif icons. Maybe they can be removed?
Then this could be version 4.8. Any further ideas?

Best
f

@drfho drfho requested a review from dataflake July 13, 2020 13:10
dataflake
dataflake reviewed Jul 13, 2020
View reviewed changes
Copy link
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is great but I can't review this. Whatever you use as editor for the ZMI pages completely reformatted everything so I cannot distinguish the changes. Could I ask you to leave formatting alone when you make changes?

@drfho
Copy link
Contributor Author

drfho commented Jul 13, 2020 •
edited
Loading

@dataflake
okay, sorry, you are right: the diff is not easy to judge, because I replaced spaces by tabs, I will try to revoke that and add another checkin. Actually, most lines of the 3 GUI methods are affected by changes. Now It looks a little (!) more similar to the former code:
https://github.com/zms-publishing/Products.ZMySQLDA/compare/zmi4

@dataflake dataflake merged commit 39220df into master Jul 13, 2020
@dataflake dataflake deleted the zmi4 branch July 13, 2020 16:06
@dataflake
Copy link
Member

Just released version 4.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataflake dataflake dataflake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drfho @dataflake