Fix unicode encoding by reflecting changes in mysqlclient-python #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataflake
requested changes
Jan 23, 2019
|
Sorry, I was a little bit too fast. It patches ZMySQLDA for Python2.7 but breaks Python3. I will repair that. |
bastei
force-pushed
the
unicode_literal_fix
branch
from
3af5b86 to
d76abb9
Compare
bastei
force-pushed
the
unicode_literal_fix
branch
from
d76abb9 to
014af95
Compare
|
The |
|
Yes, the fix in master is working for me. So we can consider this PR as obsolete. Thanks a lot! |
|
Version 4.0b4 is now available on PyPI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unicode_literal is not directly accessible in mysqlclient-python since 1.3.11. This PR fixes unicode_literal for Python2.7.