Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#7: MariaDB fix #9

Closed
wants to merge 1 commit into from
Closed

#7: MariaDB fix #9

wants to merge 1 commit into from

Conversation

veritazx
Copy link
Contributor

Convert version string to tuple, use tuple for comparison when checking feature availability

@dataflake dataflake self-requested a review March 23, 2019 16:17
dataflake
dataflake requested changes Mar 23, 2019
View reviewed changes
Copy link
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you make a PR, please check the outcome of the automated Travis CI tests. They all fail on Python 3 now.

I'll also note that there is no unit test for your code. Please provide one.

@dataflake dataflake self-assigned this Mar 23, 2019
@dataflake dataflake added the enhancement New feature or request label Mar 23, 2019
@dataflake
Copy link
Member

Closing this one. d47490b offers a better solution and has tests.

@dataflake dataflake closed this Mar 31, 2019
@veritazx veritazx deleted the feature/issue_7_MariaDB_version_string_fix branch May 31, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataflake dataflake dataflake requested changes

Assignees

@dataflake dataflake

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veritazx @dataflake