unAPI: Fallback to default item type if link resolution fails - #3642
Open
adomasven wants to merge 2 commits into
Open
unAPI: Fallback to default item type if link resolution fails#3642adomasven wants to merge 2 commits into
adomasven wants to merge 2 commits into
Conversation
Member
Author
|
Not sure what to do about the broken tests/CI, since the links no longer work. |
Member
|
I'm fine to merge this now if it's ready, but we should find new test cases. |
Member
Author
|
I've found some new tests and pushed. CI green now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparing unAPI for changes in the Zotero Connector where detection in browser will no longer be allowed to perform HTTP requests.
zotero/zotero-connectors#632