Add LibraryThing translator - #3643
Open
janbaykara wants to merge 1 commit into
Open
Conversation
AbeJellinek
reviewed
Sep 2, 2026
| return ''; | ||
| } | ||
|
|
||
| function originFromUrl(url) { |
Member
There was a problem hiding this comment.
This is always https://www.librarything.com, I think.
(Also the request*() methods accept relative URLs.)
AbeJellinek
reviewed
Sep 2, 2026
|
|
||
| function detectWeb(_doc, url) { | ||
| if (getUserId(url)) { | ||
| return 'multiple'; |
Member
There was a problem hiding this comment.
It looks like individual books have pages - why not support them?
AbeJellinek
reviewed
Sep 2, 2026
AbeJellinek
left a comment
AbeJellinek
left a comment
Member
There was a problem hiding this comment.
Thanks! A couple comments. I can't see any books in the collection you linked, but this generally seems to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a group importer from LibraryThing. Did this so I could pull https://www.librarything.com/catalog/HermesAmaraArchive