Open
Conversation
Update Rc for 3.3.1
Signed-off-by: sambashta <sambashta@rocketsoftware.com>
Signed-off-by: sambashta <sambashta@rocketsoftware.com>
15 tasks
base/src/environment/environment.ts
Outdated
|
|
||
| getZoweVersion(): Promise<string | undefined> { | ||
| return new Promise((resolve, reject) => { | ||
| this._queryServer().then(function (cache: any) { |
Member
There was a problem hiding this comment.
shouldnt the return be EnvironmentResponse not any?
base/src/environment/environment.ts
Outdated
Comment on lines
+149
to
+152
| if (cache.zoweVersion) { | ||
| resolve(cache.zoweVersion); | ||
| } else if (cache.userEnvironment && cache.userEnvironment.zoweVersion) { | ||
| resolve(cache.userEnvironment.zoweVersion); |
Member
There was a problem hiding this comment.
can you explain why it would be possible to have 2 different places to check?
Member
There was a problem hiding this comment.
from your other PR it looks like its never in userEnvironment.
Author
There was a problem hiding this comment.
Yes Sean, I was trying to check for optimization in my code using copilot, looks like it made changes and i missed it, removing the extra checks now
Member
|
Addresses zowe/zlux#1070 |
added 2 commits
March 20, 2026 12:12
…eVersion method Signed-off-by: sambashta <sambashta@rocketsoftware.com>
- Added server-metadata.ts apis which doesn't require authentication - Using the server-metadata in login.component.ts and launchbar-widget.component.ts for zoweVersion Signed-off-by: sambashta <sambashta@rocketsoftware.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add get method for zoweVersion
This PR addresses Issue: MVD-7445
This PR depends upon the following PRs:
zowe/zlux-server-framework#662
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments