Skip to content

some minor enhancements #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

some minor enhancements #36

wants to merge 1 commit into from

Conversation

jfmherokiller
Copy link

No description provided.

@dpogue
Copy link
Contributor

dpogue commented Nov 5, 2023

Is the change to std::enable_if_t necessary? That would bump the project from requiring C++11 to C++14, no?

@dpogue
Copy link
Contributor

dpogue commented Nov 5, 2023

Might also be worth specifying both inline and constexpr: https://quuxplusone.github.io/blog/2022/07/08/inline-constexpr/

@jfmherokiller
Copy link
Author

Is the change to std::enable_if_t necessary? That would bump the project from requiring C++11 to C++14, no?

it is not necessary I honestly thought it was part of the c++11 standard.

@jfmherokiller
Copy link
Author

Might also be worth specifying both inline and constexpr: https://quuxplusone.github.io/blog/2022/07/08/inline-constexpr/

that would only apply if i was changing variables plus inline constexpr seems to be a c++17 standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfmherokiller @dpogue